Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log.cc

Issue 2874753003: DCHECK that we don't insert nullptr into event log. (Closed)
Patch Set: Added one more check. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/logging/rtc_event_log/rtc_event_log.cc
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log.cc b/webrtc/logging/rtc_event_log/rtc_event_log.cc
index ffeb9d2e4ad33ee20900a77297206ac34431a665..7d5b6062bffe4ea01adafd3727600c4688016d46 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log.cc
+++ b/webrtc/logging/rtc_event_log/rtc_event_log.cc
@@ -572,6 +572,8 @@ void RtcEventLogImpl::LogProbeResult(int id,
}
void RtcEventLogImpl::StoreEvent(std::unique_ptr<rtclog::Event>* event) {
+ RTC_DCHECK(event != nullptr);
+ RTC_DCHECK(event->get() != nullptr);
if (!event_queue_.Insert(event)) {
LOG(LS_ERROR) << "WebRTC event log queue full. Dropping event.";
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698