Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm

Issue 2872953002: iOS audio session isInterrupted flag does not get reset correctly: (Closed)
Patch Set: added comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm
diff --git a/webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm b/webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm
index 82f4426482ad3f93ecdafe3600d1f3335a043d80..c9fd788ace88e6c6e9761861a95ca4bd1a8d4bbe 100644
--- a/webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm
+++ b/webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm
@@ -825,6 +825,12 @@ TEST_F(AudioDeviceTest, DISABLED_MeasureLoopbackLatency) {
latency_audio_stream->PrintResults();
}
+// Verifies that the AudioDeviceIOS is_interrupted_ flag is reset correctly after an iOS
henrika_webrtc 2017/05/11 08:00:28 Please use 80 characters per line as in rest of th
+// AVAudioSessionInterruptionTypeEnded notification event.
+// When AudioDeviceIOS is interrupted, is_interrupted_ set to true.
henrika_webrtc 2017/05/11 08:00:28 'is_interrupted is set to true'
+// When the audio is stopped, the RTCAudioSessionDelegate would be removed.
+// Then when the iOS AVAudioSessionInterruptionTypeEnded notification is received, the event
+// is not passed to the delegate as it is no longer in the delegates list.
henrika_webrtc 2017/05/11 08:00:28 Could you make it more clear that this is the expe
TEST_F(AudioDeviceTest, testInterruptedAudioSession) {
RTCAudioSession *session = [RTCAudioSession sharedInstance];
std::unique_ptr<webrtc::AudioDeviceIOS> audio_device;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698