Reduce dependencies on rtc::FileSystem in FileRotatingStream tests, adding helpers in webrtc::test::

webrtc/base/filerotatingstream_unittest.cc

 /*
  *  Copyright 2015 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <memory>
 
 #include "webrtc/base/arraysize.h"
 #include "webrtc/base/checks.h"
 #include "webrtc/base/filerotatingstream.h"
 #include "webrtc/base/fileutils.h"
 #include "webrtc/base/gunit.h"
 #include "webrtc/base/pathutils.h"
+#include "webrtc/test/testsupport/fileutils.h"
 
 namespace rtc {
 
+namespace {
+
+void CleanupLogDirectory(FileRotatingStream* stream) {
+  // On windows, open files can't be removed.
+  stream->Close();

[tommi, 2017/05/16 14:34:21]

nit: it feels kinda strange to do this inside here and not before the function
is called, but no biggie.

[nisse-webrtc, 2017/05/17 07:38:31]

Done.

+  for (size_t i = 0; i < stream->GetNumFiles(); i++) {

[tommi, 2017/05/16 14:34:21]

++i

[nisse-webrtc, 2017/05/17 07:38:32]

Done.

+    // Ignore return value, not all files are expected to exist.
+    webrtc::test::RemoveFile(stream->GetFilePath(i));
+  }
+}
+
+}  // namespace
+
 #if defined (WEBRTC_ANDROID)
 // Fails on Android: https://bugs.chromium.org/p/webrtc/issues/detail?id=4364.
 #define MAYBE_FileRotatingStreamTest DISABLED_FileRotatingStreamTest
 #else
 #define MAYBE_FileRotatingStreamTest FileRotatingStreamTest
 #endif
 
 class MAYBE_FileRotatingStreamTest : public ::testing::Test {
  protected:
   static const char* kFilePrefix;
   static const size_t kMaxFileSize;
 
   void Init(const std::string& dir_name,
             const std::string& file_prefix,
             size_t max_file_size,
             size_t num_log_files) {
-    Pathname test_path;
-    ASSERT_TRUE(Filesystem::GetAppTempFolder(&test_path));
+    dir_path_ = webrtc::test::OutputPath();
+
     // Append per-test output path in order to run within gtest parallel.
-    test_path.AppendFolder(dir_name);
-    ASSERT_TRUE(Filesystem::CreateFolder(test_path));
-    dir_path_ = test_path.pathname();
-    ASSERT_TRUE(dir_path_.size());
+    dir_path_.append(dir_name);
+    dir_path_.push_back(Pathname::DefaultFolderDelimiter());
+    ASSERT_TRUE(webrtc::test::CreateDir(dir_path_));
     stream_.reset(new FileRotatingStream(dir_path_, file_prefix, max_file_size,
                                          num_log_files));
   }
 
   void TearDown() override {
+    CleanupLogDirectory(stream_.get());
+    EXPECT_TRUE(webrtc::test::RemoveDir(dir_path_));
+
     stream_.reset();
-    if (dir_path_.size() && Filesystem::IsFolder(dir_path_) &&
-        Filesystem::IsTemporaryPath(dir_path_)) {
-      Filesystem::DeleteFolderAndContents(dir_path_);
-    }
   }
 
   // Writes the data to the stream and flushes it.
   void WriteAndFlush(const void* data, const size_t data_len) {
     EXPECT_EQ(SR_SUCCESS, stream_->WriteAll(data, data_len, nullptr, nullptr));
     EXPECT_TRUE(stream_->Flush());
   }
 
   // Checks that the stream reads in the expected contents and then returns an
   // end of stream result.
@@ skipping 132 matching lines @@
 #define MAYBE_CallSessionFileRotatingStreamTest \
     DISABLED_CallSessionFileRotatingStreamTest
 #else
 #define MAYBE_CallSessionFileRotatingStreamTest \
     CallSessionFileRotatingStreamTest
 #endif
 
 class MAYBE_CallSessionFileRotatingStreamTest : public ::testing::Test {
  protected:
   void Init(const std::string& dir_name, size_t max_total_log_size) {
-    Pathname test_path;
-    ASSERT_TRUE(Filesystem::GetAppTempFolder(&test_path));
+    dir_path_ = webrtc::test::OutputPath();
+
     // Append per-test output path in order to run within gtest parallel.
-    test_path.AppendFolder(dir_name);
-    ASSERT_TRUE(Filesystem::CreateFolder(test_path));
-    dir_path_ = test_path.pathname();
-    ASSERT_TRUE(dir_path_.size());
+    dir_path_.append(dir_name);
+    dir_path_.push_back(Pathname::DefaultFolderDelimiter());
+    ASSERT_TRUE(webrtc::test::CreateDir(dir_path_));
     stream_.reset(
         new CallSessionFileRotatingStream(dir_path_, max_total_log_size));
   }
 
   virtual void TearDown() {
+    CleanupLogDirectory(stream_.get());
+    EXPECT_TRUE(webrtc::test::RemoveDir(dir_path_));
+
     stream_.reset();
-    if (dir_path_.size() && Filesystem::IsFolder(dir_path_) &&
-        Filesystem::IsTemporaryPath(dir_path_)) {
-      Filesystem::DeleteFolderAndContents(dir_path_);
-    }
   }
 
   // Writes the data to the stream and flushes it.
   void WriteAndFlush(const void* data, const size_t data_len) {
     EXPECT_EQ(SR_SUCCESS, stream_->WriteAll(data, data_len, nullptr, nullptr));
     EXPECT_TRUE(stream_->Flush());
   }
 
   // Checks that the stream reads in the expected contents and then returns an
   // end of stream result.
@@ skipping 92 matching lines @@
   for (size_t i = 0; i < arraysize(expected_vals); ++i) {
     memset(expected_buffer.get(), expected_vals[i], buffer_size);
     EXPECT_EQ(SR_SUCCESS,
               stream_->ReadAll(buffer.get(), buffer_size, nullptr, nullptr));
     EXPECT_EQ(0, memcmp(buffer.get(), expected_buffer.get(), buffer_size));
   }
   EXPECT_EQ(SR_EOS, stream_->ReadAll(buffer.get(), 1, nullptr, nullptr));
 }
 
 }  // namespace rtc