Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_format_vp8_test_helper.cc

Issue 2871173008: Fix packetization logic to leave space for extensions in the last packet (Closed)
Patch Set: Impelement Danilchap@ comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_format_vp8_test_helper.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_format_vp8_test_helper.cc b/webrtc/modules/rtp_rtcp/source/rtp_format_vp8_test_helper.cc
index 8b20aebb90aff7e11ae60b690eaf2c172053689b..9b08f05e8113155b5107f4d4115fc4d62760f7aa 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_format_vp8_test_helper.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_format_vp8_test_helper.cc
@@ -68,15 +68,14 @@ void RtpFormatVp8TestHelper::GetAllPacketsAndCheck(
const bool* expected_frag_start,
size_t expected_num_packets) {
ASSERT_TRUE(inited_);
- bool last = false;
for (size_t i = 0; i < expected_num_packets; ++i) {
std::ostringstream ss;
ss << "Checking packet " << i;
SCOPED_TRACE(ss.str());
- EXPECT_TRUE(packetizer->NextPacket(&packet_, &last));
- CheckPacket(expected_sizes[i], last, expected_frag_start[i]);
+ EXPECT_TRUE(packetizer->NextPacket(&packet_));
+ CheckPacket(expected_sizes[i], i + 1 == expected_num_packets,
+ expected_frag_start[i]);
}
- EXPECT_TRUE(last);
}
// Payload descriptor
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_format_vp8.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_format_vp8_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698