Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_format.h

Issue 2871173008: Fix packetization logic to leave space for extensions in the last packet (Closed)
Patch Set: Impelement Danilchap@ comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/BUILD.gn ('k') | webrtc/modules/rtp_rtcp/source/rtp_format.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_FORMAT_H_ 11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_FORMAT_H_
12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_FORMAT_H_ 12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_FORMAT_H_
13 13
14 #include <string> 14 #include <string>
15 15
16 #include "webrtc/base/constructormagic.h" 16 #include "webrtc/base/constructormagic.h"
17 #include "webrtc/modules/include/module_common_types.h" 17 #include "webrtc/modules/include/module_common_types.h"
18 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h" 18 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
19 19
20 namespace webrtc { 20 namespace webrtc {
21 class RtpPacketToSend; 21 class RtpPacketToSend;
22 22
23 class RtpPacketizer { 23 class RtpPacketizer {
24 public: 24 public:
25 static RtpPacketizer* Create(RtpVideoCodecTypes type, 25 static RtpPacketizer* Create(RtpVideoCodecTypes type,
26 size_t max_payload_len, 26 size_t max_payload_len,
27 size_t last_packet_reduction_len,
27 const RTPVideoTypeHeader* rtp_type_header, 28 const RTPVideoTypeHeader* rtp_type_header,
28 FrameType frame_type); 29 FrameType frame_type);
29 30
30 virtual ~RtpPacketizer() {} 31 virtual ~RtpPacketizer() {}
31 32
32 virtual void SetPayloadData(const uint8_t* payload_data, 33 // Returns total number of packets which would be produced by the packetizer.
33 size_t payload_size, 34 virtual size_t SetPayloadData(
34 const RTPFragmentationHeader* fragmentation) = 0; 35 const uint8_t* payload_data,
36 size_t payload_size,
37 const RTPFragmentationHeader* fragmentation) = 0;
35 38
36 // Get the next payload with payload header. 39 // Get the next payload with payload header.
37 // Write payload and set marker bit of the |packet|. 40 // Write payload and set marker bit of the |packet|.
38 // The parameter |last_packet| is true for the last packet of the frame, false
39 // otherwise (i.e., call the function again to get the next packet).
40 // Returns true on success, false otherwise. 41 // Returns true on success, false otherwise.
41 virtual bool NextPacket(RtpPacketToSend* packet, bool* last_packet) = 0; 42 virtual bool NextPacket(RtpPacketToSend* packet) = 0;
42 43
43 virtual ProtectionType GetProtectionType() = 0; 44 virtual ProtectionType GetProtectionType() = 0;
44 45
45 virtual StorageType GetStorageType(uint32_t retransmission_settings) = 0; 46 virtual StorageType GetStorageType(uint32_t retransmission_settings) = 0;
46 47
47 virtual std::string ToString() = 0; 48 virtual std::string ToString() = 0;
48 }; 49 };
49 50
50 // TODO(sprang): Update the depacketizer to return a std::unqie_ptr with a copy 51 // TODO(sprang): Update the depacketizer to return a std::unqie_ptr with a copy
51 // of the parsed payload, rather than just a pointer into the incoming buffer. 52 // of the parsed payload, rather than just a pointer into the incoming buffer.
(...skipping 12 matching lines...) Expand all
64 65
65 virtual ~RtpDepacketizer() {} 66 virtual ~RtpDepacketizer() {}
66 67
67 // Parses the RTP payload, parsed result will be saved in |parsed_payload|. 68 // Parses the RTP payload, parsed result will be saved in |parsed_payload|.
68 virtual bool Parse(ParsedPayload* parsed_payload, 69 virtual bool Parse(ParsedPayload* parsed_payload,
69 const uint8_t* payload_data, 70 const uint8_t* payload_data,
70 size_t payload_data_length) = 0; 71 size_t payload_data_length) = 0;
71 }; 72 };
72 } // namespace webrtc 73 } // namespace webrtc
73 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_FORMAT_H_ 74 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_FORMAT_H_
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/BUILD.gn ('k') | webrtc/modules/rtp_rtcp/source/rtp_format.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698