Configured VCMTiming with sender defining delay times.

webrtc/modules/video_coding/frame_buffer2_unittest.cc

Index: webrtc/modules/video_coding/frame_buffer2_unittest.cc
diff --git a/webrtc/modules/video_coding/frame_buffer2_unittest.cc b/webrtc/modules/video_coding/frame_buffer2_unittest.cc
index 4f1c6369dc276c4b3f3a2559928429080bdbb977..fed2f0ed80116df1663e1726ebcefe4469aff2ae 100644
--- a/webrtc/modules/video_coding/frame_buffer2_unittest.cc
+++ b/webrtc/modules/video_coding/frame_buffer2_unittest.cc
@@ -260,6 +260,17 @@ TEST_F(TestFrameBuffer2, OneSuperFrame) {
   CheckFrame(1, pid, 1);
 }
 
+TEST_F(TestFrameBuffer2, SetPlayoutDelay) {
+  int minimal_playout_delay_ms = -213;

[philipel, 2017/05/09 14:34:47]

Constants are defined like this "const kMinimalPlayoutDelayMs = -213"

Also, please don't use invalid values. Often people read the unittests to
understand what a particular class is suppose to do, and this might confuse
them.

+  int maximal_playout_delay_ms = -10000;

[philipel, 2017/05/09 14:34:47]

Also a constant :)

+  std::unique_ptr<FrameObjectFake> test_frame(new FrameObjectFake());
+  test_frame->SetPlayoutDelay(minimal_playout_delay_ms,
+                              maximal_playout_delay_ms);
+  buffer_.InsertFrame(std::move(test_frame));
+  EXPECT_EQ(timing_.min_playout_delay(), -1);

[philipel, 2017/05/09 14:34:47]

Shouldn't these values be equal to the constants defined on line 264/265?

[philipel, 2017/05/09 14:34:47]

In general we do EXPECT_EQ(<the expected value>, <value to test>) so when an
error occur it generates a nice error message, we should change this to
EXPECT_EQ(-1, timing_.min_playout_delay());

+  EXPECT_EQ(timing_.max_playout_delay(), -1);
+}
+
 // Flaky test, see bugs.webrtc.org/7068.
 TEST_F(TestFrameBuffer2, DISABLED_OneUnorderedSuperFrame) {
   uint16_t pid = Rand();