webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc - Issue 2867943003: New class RtpDemuxer and RtpPacketSinkInterface, use in Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc

Issue 2867943003: New class RtpDemuxer and RtpPacketSinkInterface, use in Call. (Closed)

Patch Set: Fix Flexfec recursion issue in a different way. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc

diff --git a/webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc b/webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc

index 47534e480e561078f0961bfd326351edb18b4539..a365fcbec43e938f6b97667e6801c64ca75684c9 100644

--- a/webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc

+++ b/webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc

@@ -132,9 +132,11 @@ bool FlexfecReceiver::ProcessReceivedPackets() {

continue;

}

++packet_counter_.num_recovered_packets;

+ // Set this flag first, since OnRecoveredPacket may end up here

brandtr 2017/05/16 08:19:39 I'll look into why this is the case.

+ // again, with the same packet.

+ recovered_packet->returned = true;

recovered_packet_receiver_->OnRecoveredPacket(

recovered_packet->pkt->data, recovered_packet->pkt->length);

- recovered_packet->returned = true;

// Periodically log the incoming packets.

int64_t now_ms = clock_->TimeInMilliseconds();

if (now_ms - last_recovered_packet_ms_ > kPacketLogIntervalMs) {

« no previous file with comments | « webrtc/call/rtp_demuxer.cc ('k') | webrtc/video/video_receive_stream.h » ('j') | no next file with comments »