Remove hardcoded kValueSizeBytes values from variable-length header extensions.

webrtc/modules/rtp_rtcp/include/flexfec_sender.h

Index: webrtc/modules/rtp_rtcp/include/flexfec_sender.h
diff --git a/webrtc/modules/rtp_rtcp/include/flexfec_sender.h b/webrtc/modules/rtp_rtcp/include/flexfec_sender.h
index e69daf3ff06b8360b7d4216a689d9e230c0be6a8..8ae3f53486bb8ba06ee163cea5b20b5fe7bc42de 100644
--- a/webrtc/modules/rtp_rtcp/include/flexfec_sender.h
+++ b/webrtc/modules/rtp_rtcp/include/flexfec_sender.h
@@ -14,6 +14,7 @@
 #include <memory>
 #include <vector>
 
+#include "webrtc/base/array_view.h"
 #include "webrtc/base/basictypes.h"
 #include "webrtc/base/random.h"
 #include "webrtc/base/sequenced_task_checker.h"
@@ -38,6 +39,7 @@ class FlexfecSender {
                 uint32_t ssrc,
                 uint32_t protected_media_ssrc,
                 const std::vector<RtpExtension>& rtp_header_extensions,
+                rtc::ArrayView<const RtpExtensionSize> extension_sizes,
                 Clock* clock);
   ~FlexfecSender();
 
@@ -59,7 +61,10 @@ class FlexfecSender {
   // Returns generated FlexFEC packets.
   std::vector<std::unique_ptr<RtpPacketToSend>> GetFecPackets();
 
-  // Returns the overhead, per packet, for FlexFEC.
+  // Returns the overhead, per packet, for FlexFEC. |extension_sizes| is used
+  // to calculate the RTP header extension overhead and it should have an entry

[brandtr, 2017/05/10 14:36:27]

I think this comment is redundant now?

[erikvarga1, 2017/05/10 15:39:31]

Oops, I forgot to remove that. Removed now.

+  // for each extension that a packet might use. If only fixed-length extensions
+  // are used, |extension_sizes| should be the same at each call.
   size_t MaxPacketOverhead() const;
 
  private:
@@ -79,6 +84,7 @@ class FlexfecSender {
   // Implementation.
   UlpfecGenerator ulpfec_generator_;
   const RtpHeaderExtensionMap rtp_header_extension_map_;
+  size_t header_extensions_size_;

[brandtr, 2017/05/10 14:36:27]

Can you make this const?

[erikvarga1, 2017/05/10 15:39:31]

Done.

 };
 
 }  // namespace webrtc