webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc - Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions. (Closed)

Patch Set: Patch 1 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

diff --git a/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc b/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

index b53574c625c3ffdf6a4234ee2eb5ad0bb53d15e6..e8a725e3789ef64d953a47924d43551d967e52df 100644

--- a/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

+++ b/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

@@ -136,7 +136,8 @@ TEST_F(RtpRtcpAPITest, Basic) {

TEST_F(RtpRtcpAPITest, PacketSize) {

module_->SetMaxRtpPacketSize(1234);

EXPECT_EQ(1234u, module_->MaxRtpPacketSize());

- EXPECT_EQ(1234u - 12u /* Minimum RTP header */, module_->MaxPayloadSize());

+ EXPECT_EQ(1234u - 12u /* Minimum RTP header */,

+ module_->MaxPayloadSize({} /* extension_sizes */));

}

TEST_F(RtpRtcpAPITest, SSRC) {