Remove hardcoded kValueSizeBytes values from variable-length header extensions.

webrtc/modules/rtp_rtcp/source/rtp_sender.h

Index: webrtc/modules/rtp_rtcp/source/rtp_sender.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.h b/webrtc/modules/rtp_rtcp/source/rtp_sender.h
index dc35a038e1de6f9d09cc24eec04ff326f6e039c0..dc08bdffe4fbb09f923b2f8b54d11f2b21e9e0ae 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.h
@@ -63,6 +63,9 @@ class RTPSender {
 
   ~RTPSender();
 
+  // Size info for header extensions used by FEC packets.
+  static rtc::ArrayView<const RtpExtensionSize> FecExtensionSizes();

[danilchap, 2017/05/09 12:33:49]

may be declare it it near AllocatePacket function, since this return sizes for
same extensions AllocatePacket aware about.

[erikvarga1, 2017/05/09 13:30:31]

Done. I thought for some reason that static functions needed to be placed at the
top, but now that I checked, I don't see anything like that in the style guide.

[danilchap, 2017/05/09 14:45:22]

Factory methods should be placed at the top (and factory methods are common
reason to use static functions)

+
   void ProcessBitrate();
 
   uint16_t ActualSendBitrateKbit() const;
@@ -72,7 +75,8 @@ class RTPSender {
   uint32_t NackOverheadRate() const;
 
   // Excluding size of RTP and FEC headers.
-  size_t MaxPayloadSize() const;
+  size_t MaxPayloadSize(
+      rtc::ArrayView<const RtpExtensionSize> extension_sizes) const;
 
   int32_t RegisterPayload(const char* payload_name,
                           const int8_t payload_type,
@@ -156,7 +160,8 @@ class RTPSender {
   // Return false if sending was turned off.
   bool AssignSequenceNumber(RtpPacketToSend* packet);
 
-  size_t RtpHeaderLength() const;
+  size_t RtpHeaderLength(
+      rtc::ArrayView<const RtpExtensionSize> extension_sizes) const;
   uint16_t AllocateSequenceNumber(uint16_t packets_to_send);
   // Including RTP headers.
   size_t MaxRtpPacketSize() const;