webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h - Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions. (Closed)

Patch Set: Patch 1 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

index 13bdac020be478eb0fdf365a9d01fb66b093d174..cdb5d776fd4a943582d345e9107ddab71fdc36c1 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

@@ -209,7 +209,8 @@ class ModuleRtpRtcpImpl : public RtpRtcp, public RTCPReceiver::ModuleRtpRtcp {

void SetTmmbn(std::vector<rtcp::TmmbItem> bounding_set) override;

- size_t MaxPayloadSize() const override;

+ size_t MaxPayloadSize(

+ rtc::ArrayView<const RtpExtensionSize> extension_sizes) const override;

size_t MaxRtpPacketSize() const override;