Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc

Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions. (Closed)
Patch Set: Patch 1 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc
index 179d27985fc36ce86c952df1f96b72f56976c440..51942b3033a113b5c9b437988ad1b9b7e8db8878 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc
@@ -85,11 +85,15 @@ TEST(RtpHeaderExtensionTest, NonUniqueId) {
TEST(RtpHeaderExtensionTest, GetTotalLength) {
RtpHeaderExtensionMap map;
- EXPECT_EQ(0u, map.GetTotalLengthInBytes());
+ constexpr RtpExtensionSize kExtensionSizes[] = {
+ CreateExtensionSize<TransmissionOffset>(),
+ };
+ EXPECT_EQ(0u, map.GetTotalLengthInBytes(kExtensionSizes));
EXPECT_TRUE(map.Register<TransmissionOffset>(3));
static constexpr size_t kRtpOneByteHeaderLength = 4;
- EXPECT_EQ(kRtpOneByteHeaderLength + (TransmissionOffset::kValueSizeBytes + 1),
- map.GetTotalLengthInBytes());
+ EXPECT_EQ(
+ kRtpOneByteHeaderLength + (TransmissionOffset::kValueSizeBytes + 1),
+ map.GetTotalLengthInBytes(kExtensionSizes));
}
TEST(RtpHeaderExtensionTest, GetType) {

Powered by Google App Engine
This is Rietveld 408576698