webrtc/modules/rtp_rtcp/source/flexfec_sender_unittest.cc - Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/flexfec_sender_unittest.cc

Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions. (Closed)

Patch Set: Patch 1 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/flexfec_sender_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/flexfec_sender_unittest.cc b/webrtc/modules/rtp_rtcp/source/flexfec_sender_unittest.cc

index c906750fe3e20e4a80b85a469d6e10699b023110..e8f49b26ca95bf3dc73edbf65c77e5c8d0c70913 100644

--- a/webrtc/modules/rtp_rtcp/source/flexfec_sender_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/flexfec_sender_unittest.cc

@@ -254,7 +254,8 @@ TEST(FlexfecSenderTest, MaxPacketOverhead) {

FlexfecSender sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,

kNoRtpHeaderExtensions, &clock);

- EXPECT_EQ(kFlexfecMaxHeaderSize, sender.MaxPacketOverhead());

+ EXPECT_EQ(kFlexfecMaxHeaderSize,

+ sender.MaxPacketOverhead({} /* extension_sizes */));

}

} // namespace webrtc