webrtc/modules/congestion_controller/send_side_congestion_controller.cc - Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/send_side_congestion_controller.cc

Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions. (Closed)

Patch Set: use RaceChecker instead of ThreadChecker in a few places. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/congestion_controller/include/send_side_congestion_controller.h ('k') | webrtc/modules/pacing/packet_router.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/send_side_congestion_controller.cc

diff --git a/webrtc/modules/congestion_controller/send_side_congestion_controller.cc b/webrtc/modules/congestion_controller/send_side_congestion_controller.cc

index 57e7685f88f52362de74e20ac300c41a09aa5c79..e5f7fb9c3a32c26ecdb7d7c8851bf514caa6ce66 100644

--- a/webrtc/modules/congestion_controller/send_side_congestion_controller.cc

+++ b/webrtc/modules/congestion_controller/send_side_congestion_controller.cc

@@ -101,7 +101,6 @@ SendSideCongestionController::SendSideCongestionController(

min_bitrate_bps_(congestion_controller::GetMinBitrateBps()),

delay_based_bwe_(new DelayBasedBwe(event_log_, clock_)) {

delay_based_bwe_->SetMinBitrate(min_bitrate_bps_);

- worker_thread_checker_.DetachFromThread();

}

SendSideCongestionController::~SendSideCongestionController() {}

@@ -273,7 +272,7 @@ void SendSideCongestionController::AddPacket(

void SendSideCongestionController::OnTransportFeedback(

const rtcp::TransportFeedback& feedback) {

- RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());

+ RTC_DCHECK_RUNS_SERIALIZED(&race_checker_);

transport_feedback_adapter_.OnTransportFeedback(feedback);

std::vector<PacketFeedback> feedback_vector = ReceivedPacketFeedbackVector(

transport_feedback_adapter_.GetTransportFeedbackVector());

@@ -292,7 +291,7 @@ void SendSideCongestionController::OnTransportFeedback(

std::vector<PacketFeedback>

SendSideCongestionController::GetTransportFeedbackVector() const {

- RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());

+ RTC_DCHECK_RUNS_SERIALIZED(&race_checker_);

return transport_feedback_adapter_.GetTransportFeedbackVector();

}