webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc - Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions. (Closed)

Patch Set: Patch 7 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender.cc ('k') | webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc » ('j') | webrtc/test/fuzzers/flexfec_sender_fuzzer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

index 961b53a139c3901984ee907fc10d491a68210b3a..70f27d06516add6218882b57af00748e7cd024b4 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

@@ -843,8 +843,10 @@ TEST_P(RtpSenderTest, SendFlexfecPackets) {

constexpr uint32_t kMediaSsrc = 1234;

constexpr uint32_t kFlexfecSsrc = 5678;

const std::vector<RtpExtension> kNoRtpExtensions;

+ const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;

FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,

- kNoRtpExtensions, &fake_clock_);

+ kNoRtpExtensions, kNoRtpExtensionSizes,

+ &fake_clock_);

// Reset |rtp_sender_| to use FlexFEC.

rtp_sender_.reset(new RTPSender(

@@ -898,8 +900,10 @@ TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {

constexpr uint32_t kMediaSsrc = 1234;

constexpr uint32_t kFlexfecSsrc = 5678;

const std::vector<RtpExtension> kNoRtpExtensions;

+ const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;

FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,

- kNoRtpExtensions, &fake_clock_);

+ kNoRtpExtensions, kNoRtpExtensionSizes,

+ &fake_clock_);

// Reset |rtp_sender_| to use FlexFEC.

rtp_sender_.reset(new RTPSender(false, &fake_clock_, &transport_, nullptr,

@@ -937,8 +941,10 @@ TEST_P(RtpSenderTest, FecOverheadRate) {

constexpr uint32_t kMediaSsrc = 1234;

constexpr uint32_t kFlexfecSsrc = 5678;

const std::vector<RtpExtension> kNoRtpExtensions;

+ const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;

FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,

- kNoRtpExtensions, &fake_clock_);

+ kNoRtpExtensions, kNoRtpExtensionSizes,

+ &fake_clock_);

// Reset |rtp_sender_| to use FlexFEC.

rtp_sender_.reset(new RTPSender(