webrtc/modules/rtp_rtcp/include/flexfec_sender.h - Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/include/flexfec_sender.h

Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/include/flexfec_sender.h

diff --git a/webrtc/modules/rtp_rtcp/include/flexfec_sender.h b/webrtc/modules/rtp_rtcp/include/flexfec_sender.h

index e69daf3ff06b8360b7d4216a689d9e230c0be6a8..5551f2a6911eba5e44d43ca13bc52608b9d88194 100644

--- a/webrtc/modules/rtp_rtcp/include/flexfec_sender.h

+++ b/webrtc/modules/rtp_rtcp/include/flexfec_sender.h

@@ -60,7 +60,8 @@ class FlexfecSender {

std::vector<std::unique_ptr<RtpPacketToSend>> GetFecPackets();

// Returns the overhead, per packet, for FlexFEC.

danilchap 2017/05/08 16:25:05 add description for the parameter. Can it have dif

erikvarga1 2017/05/09 11:40:03 Done.

- size_t MaxPacketOverhead() const;

+ size_t MaxPacketOverhead(

+ rtc::ArrayView<const RTPExtensionSizeInfo> extension_sizes) const;

private:

// Utility.