Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h

Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions. (Closed)
Patch Set: Patch 5 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_HEADER_EXTENSIONS_H_ 10 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_HEADER_EXTENSIONS_H_
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 "http://www.webrtc.org/experiments/rtp-hdrext/video-content-type"; 108 "http://www.webrtc.org/experiments/rtp-hdrext/video-content-type";
109 109
110 static bool Parse(rtc::ArrayView<const uint8_t> data, 110 static bool Parse(rtc::ArrayView<const uint8_t> data,
111 VideoContentType* content_type); 111 VideoContentType* content_type);
112 static bool Write(uint8_t* data, VideoContentType content_type); 112 static bool Write(uint8_t* data, VideoContentType content_type);
113 }; 113 };
114 114
115 class RtpStreamId { 115 class RtpStreamId {
116 public: 116 public:
117 static constexpr RTPExtensionType kId = kRtpExtensionRtpStreamId; 117 static constexpr RTPExtensionType kId = kRtpExtensionRtpStreamId;
118 // TODO(danilchap): Implement write support of dynamic size extension that
119 // allows to remove the ValueSize constant.
120 static constexpr uint8_t kValueSizeBytes = 1;
121 static constexpr const char* kUri = 118 static constexpr const char* kUri =
122 "urn:ietf:params:rtp-hdrext:sdes:rtp-stream-id"; 119 "urn:ietf:params:rtp-hdrext:sdes:rtp-stream-id";
123 120
124 static bool Parse(rtc::ArrayView<const uint8_t> data, StreamId* rid); 121 static bool Parse(rtc::ArrayView<const uint8_t> data, StreamId* rid);
125 static bool Parse(rtc::ArrayView<const uint8_t> data, std::string* rid); 122 static bool Parse(rtc::ArrayView<const uint8_t> data, std::string* rid);
126 }; 123 };
127 124
128 class RepairedRtpStreamId { 125 class RepairedRtpStreamId {
129 public: 126 public:
130 static constexpr RTPExtensionType kId = kRtpExtensionRepairedRtpStreamId; 127 static constexpr RTPExtensionType kId = kRtpExtensionRepairedRtpStreamId;
131 // TODO(danilchap): Implement write support of dynamic size extension that
132 // allows to remove the ValueSize constant.
133 static constexpr uint8_t kValueSizeBytes = 1;
134 static constexpr const char* kUri = 128 static constexpr const char* kUri =
135 "urn:ietf:params:rtp-hdrext:sdes:repaired-rtp-stream-id"; 129 "urn:ietf:params:rtp-hdrext:sdes:repaired-rtp-stream-id";
136 130
137 static bool Parse(rtc::ArrayView<const uint8_t> data, StreamId* rid); 131 static bool Parse(rtc::ArrayView<const uint8_t> data, StreamId* rid);
138 static bool Parse(rtc::ArrayView<const uint8_t> data, std::string* rid); 132 static bool Parse(rtc::ArrayView<const uint8_t> data, std::string* rid);
139 }; 133 };
140 134
141 } // namespace webrtc 135 } // namespace webrtc
142 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_HEADER_EXTENSIONS_H_ 136 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_HEADER_EXTENSIONS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698