AecDump implementation.

webrtc/modules/audio_processing/aec_dump/aec_dump_factory.h

Index: webrtc/modules/audio_processing/aec_dump/aec_dump_factory.h
diff --git a/webrtc/modules/audio_processing/aec_dump/aec_dump_factory.h b/webrtc/modules/audio_processing/aec_dump/aec_dump_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..98596a4568b7b21afb691aad8ccba483a7579b3d
--- /dev/null
+++ b/webrtc/modules/audio_processing/aec_dump/aec_dump_factory.h
@@ -0,0 +1,47 @@
+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_AUDIO_PROCESSING_AEC_DUMP_AEC_DUMP_FACTORY_H_
+#define WEBRTC_MODULES_AUDIO_PROCESSING_AEC_DUMP_AEC_DUMP_FACTORY_H_
+
+#include <memory>
+#include <string>
+
+#include "webrtc/base/platform_file.h"
+#include "webrtc/modules/audio_processing/include/aec_dump.h"
+
+namespace rtc {
+class TaskQueue;
+}  // namespace rtc
+
+namespace webrtc {
+
+class AecDumpFactory {
+ public:
+  // The |worker_queue| may not be null and must outlive the created

[peah-webrtc, 2017/05/17 05:36:32]

Regarding this: I know we discussed it but is there no way of avoid this
requirement? What if
log_size_bytes is created dynamically, and both the file-pointer and
log_size_bytes are made reference counted? 
Then the worker thread would not need to outlive the AecDump instance as no
explicit synchronization, right? Furthermore, the AecDump instance does not need
to outlive the last posted dumped packet, as the reference counted pointer will
pass ownership to the Tasks once the AecDump instance is destroyed, right?

It would simplify the use of this a lot if we don't have to have the requirement
that one of these need to outlive the others which seems as something that
definitely will go wrong at some point.

WDYT?

[aleloi, 2017/05/17 10:49:55]

Acknowledged.

+  // AecDump instance. |max_log_size_bytes == -1| means the log size
+  // will be unlimited. |handle| may not be null. The AecDump takes
+  // responsibility for |handle| and closes it in the destructor. A
+  // non-null return value indicates that the file has been
+  // sucessfully opened.
+  static std::unique_ptr<AecDump> Create(rtc::PlatformFile file,
+                                         int64_t max_log_size_bytes,
+                                         rtc::TaskQueue* worker_queue);
+  static std::unique_ptr<AecDump> Create(std::string file_name,
+                                         int64_t max_log_size_bytes,
+                                         rtc::TaskQueue* worker_queue);
+  static std::unique_ptr<AecDump> Create(FILE* handle,
+                                         int64_t max_log_size_bytes,
+                                         rtc::TaskQueue* worker_queue);
+};
+
+}  // namespace webrtc
+
+#endif  // WEBRTC_MODULES_AUDIO_PROCESSING_AEC_DUMP_AEC_DUMP_FACTORY_H_