Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: webrtc/pc/channel.h

Issue 2863123002: Wire up BWE stats through WebrtcSession so that they are filled in both for audio and video calls. (Closed)
Patch Set: Comments addressed, generalized InvokeOnWorker(). Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/pc/channel.h
diff --git a/webrtc/pc/channel.h b/webrtc/pc/channel.h
index 48259e5fd9d7732b94c4deaa817265edf5b85b59..8871bd83afd0bceb0871a9abc653470f197d9870 100644
--- a/webrtc/pc/channel.h
+++ b/webrtc/pc/channel.h
@@ -351,10 +351,9 @@ class BaseChannel
const std::vector<ConnectionInfo>& infos) = 0;
// Helper function for invoking bool-returning methods on the worker thread.
hbos 2017/05/09 12:48:14 nit: Update comment.
holmer 2017/05/30 14:44:28 Done.
- template <class FunctorT>
- bool InvokeOnWorker(const rtc::Location& posted_from,
- const FunctorT& functor) {
- return worker_thread_->Invoke<bool>(posted_from, functor);
+ template <class T, class FunctorT>
+ T InvokeOnWorker(const rtc::Location& posted_from, const FunctorT& functor) {
+ return worker_thread_->Invoke<T>(posted_from, functor);
}
private:
@@ -554,6 +553,7 @@ class VideoChannel : public BaseChannel {
bool SetSink(uint32_t ssrc,
rtc::VideoSinkInterface<webrtc::VideoFrame>* sink);
+ void FillBitrateInfo(BandwidthEstimationInfo* bwe_info);
hbos 2017/05/09 12:48:14 Why is this only in VideoChannel and not also in V
holmer 2017/05/30 14:44:28 We should probably add it to VoiceChannel later as
hbos 2017/05/31 14:31:58 Acknowledged.
// Get statistics about the current media session.
bool GetStats(VideoMediaInfo* stats);

Powered by Google App Engine
This is Rietveld 408576698