webrtc/media/engine/webrtcvideoengine2.h - Issue 2863123002: Wire up BWE stats through WebrtcSession so that they are filled in both for audio and video calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvideoengine2.h

Issue 2863123002: Wire up BWE stats through WebrtcSession so that they are filled in both for audio and video calls. (Closed)

Patch Set: Comments addressed." Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/webrtcvideoengine2.h

diff --git a/webrtc/media/engine/webrtcvideoengine2.h b/webrtc/media/engine/webrtcvideoengine2.h

index 394646bc3278bee5d1e52fcd77b067d958281953..56431167a8397f06b4f1c70de3df8cfd06d18231 100644

--- a/webrtc/media/engine/webrtcvideoengine2.h

+++ b/webrtc/media/engine/webrtcvideoengine2.h

@@ -160,6 +160,7 @@ class WebRtcVideoChannel2 : public VideoMediaChannel, public webrtc::Transport {

bool RemoveRecvStream(uint32_t ssrc) override;

bool SetSink(uint32_t ssrc,

rtc::VideoSinkInterface<webrtc::VideoFrame>* sink) override;

+ void FillBitrateInfo(BandwidthEstimationInfo* bwe_info) override;

bool GetStats(VideoMediaInfo* info) override;

void OnPacketReceived(rtc::CopyOnWriteBuffer* packet,

@@ -284,7 +285,7 @@ class WebRtcVideoChannel2 : public VideoMediaChannel, public webrtc::Transport {

const std::vector<uint32_t>& GetSsrcs() const;

VideoSenderInfo GetVideoSenderInfo(bool log_stats);

- void FillBandwidthEstimationInfo(BandwidthEstimationInfo* bwe_info);

+ void FillBitrateInfo(BandwidthEstimationInfo* bwe_info);

private:

// Parameters needed to reconstruct the underlying stream.

« no previous file with comments | « webrtc/media/base/mediachannel.h ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »