 Chromium Code Reviews
 Chromium Code Reviews Issue 2863123002:
  Wire up BWE stats through WebrtcSession so that they are filled in both for audio and video calls.  (Closed)
    
  
    Issue 2863123002:
  Wire up BWE stats through WebrtcSession so that they are filled in both for audio and video calls.  (Closed) 
  | Index: webrtc/pc/statscollector_unittest.cc | 
| diff --git a/webrtc/pc/statscollector_unittest.cc b/webrtc/pc/statscollector_unittest.cc | 
| index 7d75f6530293857461adcc535e2571d67014b355..7028943dc224dde3be784ffcccc178f8f00a9cb9 100644 | 
| --- a/webrtc/pc/statscollector_unittest.cc | 
| +++ b/webrtc/pc/statscollector_unittest.cc | 
| @@ -938,12 +938,15 @@ TEST_F(StatsCollectorTest, BandwidthEstimationInfoIsReported) { | 
| video_sender_info.add_ssrc(1234); | 
| video_sender_info.bytes_sent = kBytesSent; | 
| stats_read.senders.push_back(video_sender_info); | 
| - cricket::BandwidthEstimationInfo bwe; | 
| - const int kTargetEncBitrate = 123456; | 
| - const std::string kTargetEncBitrateString("123456"); | 
| - bwe.target_enc_bitrate = kTargetEncBitrate; | 
| - stats_read.bw_estimations.push_back(bwe); | 
| + webrtc::Call::Stats call_stats; | 
| + const int kSendBandwidth = 1234567; | 
| + call_stats.send_bandwidth_bps = kSendBandwidth; | 
| + const int kRecvBandwidth = 12345678; | 
| + call_stats.recv_bandwidth_bps = kRecvBandwidth; | 
| + const int kPacerDelay = 123; | 
| 
Taylor Brandstetter
2017/05/07 21:30:44
nit: It would be more readable to me if the consta
 
stefan-webrtc
2017/05/08 07:12:57
Done.
 | 
| + call_stats.pacer_delay_ms = kPacerDelay; | 
| + EXPECT_CALL(session_, GetCallStats()).WillRepeatedly(Return(call_stats)); | 
| EXPECT_CALL(session_, video_channel()).WillRepeatedly(Return(&video_channel)); | 
| EXPECT_CALL(session_, voice_channel()).WillRepeatedly(ReturnNull()); | 
| EXPECT_CALL(*media_channel, GetStats(_)) | 
| @@ -954,9 +957,15 @@ TEST_F(StatsCollectorTest, BandwidthEstimationInfoIsReported) { | 
| std::string result = ExtractSsrcStatsValue(reports, | 
| StatsReport::kStatsValueNameBytesSent); | 
| EXPECT_EQ(kBytesSentString, result); | 
| - result = ExtractBweStatsValue(reports, | 
| - StatsReport::kStatsValueNameTargetEncBitrate); | 
| - EXPECT_EQ(kTargetEncBitrateString, result); | 
| + result = ExtractBweStatsValue( | 
| + reports, StatsReport::kStatsValueNameAvailableSendBandwidth); | 
| + EXPECT_EQ(rtc::ToString(kSendBandwidth), result); | 
| + result = ExtractBweStatsValue( | 
| + reports, StatsReport::kStatsValueNameAvailableReceiveBandwidth); | 
| + EXPECT_EQ(rtc::ToString(kRecvBandwidth), result); | 
| + result = | 
| + ExtractBweStatsValue(reports, StatsReport::kStatsValueNameBucketDelay); | 
| + EXPECT_EQ(rtc::ToString(kPacerDelay), result); | 
| } | 
| // This test verifies that an object of type "googSession" always |