Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: webrtc/pc/webrtcsession.h

Issue 2863123002: Wire up BWE stats through WebrtcSession so that they are filled in both for audio and video calls. (Closed)
Patch Set: Comments addresed. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_PC_WEBRTCSESSION_H_ 11 #ifndef WEBRTC_PC_WEBRTCSESSION_H_
12 #define WEBRTC_PC_WEBRTCSESSION_H_ 12 #define WEBRTC_PC_WEBRTCSESSION_H_
13 13
14 #include <memory> 14 #include <memory>
15 #include <set> 15 #include <set>
16 #include <string> 16 #include <string>
17 #include <vector> 17 #include <vector>
18 18
19 #include "webrtc/api/peerconnectioninterface.h" 19 #include "webrtc/api/peerconnectioninterface.h"
20 #include "webrtc/api/statstypes.h" 20 #include "webrtc/api/statstypes.h"
21 #include "webrtc/base/constructormagic.h" 21 #include "webrtc/base/constructormagic.h"
22 #include "webrtc/base/optional.h" 22 #include "webrtc/base/optional.h"
23 #include "webrtc/base/sigslot.h" 23 #include "webrtc/base/sigslot.h"
24 #include "webrtc/base/sslidentity.h" 24 #include "webrtc/base/sslidentity.h"
25 #include "webrtc/base/thread.h" 25 #include "webrtc/base/thread.h"
26 #include "webrtc/media/base/mediachannel.h" 26 #include "webrtc/call/call.h"
27 #include "webrtc/p2p/base/candidate.h" 27 #include "webrtc/p2p/base/candidate.h"
28 #include "webrtc/p2p/base/transportcontroller.h" 28 #include "webrtc/p2p/base/transportcontroller.h"
29 #include "webrtc/pc/datachannel.h" 29 #include "webrtc/pc/datachannel.h"
30 #include "webrtc/pc/mediasession.h" 30 #include "webrtc/pc/mediasession.h"
31 31
32 #ifdef HAVE_QUIC 32 #ifdef HAVE_QUIC
33 #include "webrtc/pc/quicdatatransport.h" 33 #include "webrtc/pc/quicdatatransport.h"
34 #endif // HAVE_QUIC 34 #endif // HAVE_QUIC
35 35
36 namespace cricket { 36 namespace cricket {
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 // Implements DataChannelProviderInterface. 287 // Implements DataChannelProviderInterface.
288 bool SendData(const cricket::SendDataParams& params, 288 bool SendData(const cricket::SendDataParams& params,
289 const rtc::CopyOnWriteBuffer& payload, 289 const rtc::CopyOnWriteBuffer& payload,
290 cricket::SendDataResult* result) override; 290 cricket::SendDataResult* result) override;
291 bool ConnectDataChannel(DataChannel* webrtc_data_channel) override; 291 bool ConnectDataChannel(DataChannel* webrtc_data_channel) override;
292 void DisconnectDataChannel(DataChannel* webrtc_data_channel) override; 292 void DisconnectDataChannel(DataChannel* webrtc_data_channel) override;
293 void AddSctpDataStream(int sid) override; 293 void AddSctpDataStream(int sid) override;
294 void RemoveSctpDataStream(int sid) override; 294 void RemoveSctpDataStream(int sid) override;
295 bool ReadyToSendData() const override; 295 bool ReadyToSendData() const override;
296 296
297 virtual Call::Stats GetCallStats();
298 Call::Stats GetCallStats_s();
Taylor Brandstetter 2017/05/31 00:03:51 Do both of these need to be public?
299
297 // Returns stats for all channels of all transports. 300 // Returns stats for all channels of all transports.
298 // This avoids exposing the internal structures used to track them. 301 // This avoids exposing the internal structures used to track them.
299 // The parameterless version creates |ChannelNamePairs| from |voice_channel|, 302 // The parameterless version creates |ChannelNamePairs| from |voice_channel|,
300 // |video_channel| and |voice_channel| if available - this requires it to be 303 // |video_channel| and |voice_channel| if available - this requires it to be
301 // called on the signaling thread - and invokes the other |GetStats|. The 304 // called on the signaling thread - and invokes the other |GetStats|. The
302 // other |GetStats| can be invoked on any thread; if not invoked on the 305 // other |GetStats| can be invoked on any thread; if not invoked on the
303 // network thread a thread hop will happen. 306 // network thread a thread hop will happen.
304 std::unique_ptr<SessionStats> GetStats_s(); 307 std::unique_ptr<SessionStats> GetStats_s();
305 virtual std::unique_ptr<SessionStats> GetStats( 308 virtual std::unique_ptr<SessionStats> GetStats(
306 const ChannelNamePairs& channel_name_pairs); 309 const ChannelNamePairs& channel_name_pairs);
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
638 641
639 #ifdef HAVE_QUIC 642 #ifdef HAVE_QUIC
640 std::unique_ptr<QuicDataTransport> quic_data_transport_; 643 std::unique_ptr<QuicDataTransport> quic_data_transport_;
641 #endif // HAVE_QUIC 644 #endif // HAVE_QUIC
642 645
643 RTC_DISALLOW_COPY_AND_ASSIGN(WebRtcSession); 646 RTC_DISALLOW_COPY_AND_ASSIGN(WebRtcSession);
644 }; 647 };
645 } // namespace webrtc 648 } // namespace webrtc
646 649
647 #endif // WEBRTC_PC_WEBRTCSESSION_H_ 650 #endif // WEBRTC_PC_WEBRTCSESSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698