Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: webrtc/media/base/mediachannel.h

Issue 2863123002: Wire up BWE stats through WebrtcSession so that they are filled in both for audio and video calls. (Closed)
Patch Set: Comments addressed." Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/base/fakemediaengine.h ('k') | webrtc/media/engine/webrtcvideoengine2.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 844 matching lines...) Expand 10 before | Expand all | Expand 10 after
855 std::vector<VoiceSenderInfo> senders; 855 std::vector<VoiceSenderInfo> senders;
856 std::vector<VoiceReceiverInfo> receivers; 856 std::vector<VoiceReceiverInfo> receivers;
857 RtpCodecParametersMap send_codecs; 857 RtpCodecParametersMap send_codecs;
858 RtpCodecParametersMap receive_codecs; 858 RtpCodecParametersMap receive_codecs;
859 }; 859 };
860 860
861 struct VideoMediaInfo { 861 struct VideoMediaInfo {
862 void Clear() { 862 void Clear() {
863 senders.clear(); 863 senders.clear();
864 receivers.clear(); 864 receivers.clear();
865 bw_estimations.clear();
866 send_codecs.clear(); 865 send_codecs.clear();
867 receive_codecs.clear(); 866 receive_codecs.clear();
868 } 867 }
869 std::vector<VideoSenderInfo> senders; 868 std::vector<VideoSenderInfo> senders;
870 std::vector<VideoReceiverInfo> receivers; 869 std::vector<VideoReceiverInfo> receivers;
871 std::vector<BandwidthEstimationInfo> bw_estimations;
872 RtpCodecParametersMap send_codecs; 870 RtpCodecParametersMap send_codecs;
873 RtpCodecParametersMap receive_codecs; 871 RtpCodecParametersMap receive_codecs;
874 }; 872 };
875 873
876 struct DataMediaInfo { 874 struct DataMediaInfo {
877 void Clear() { 875 void Clear() {
878 senders.clear(); 876 senders.clear();
879 receivers.clear(); 877 receivers.clear();
880 } 878 }
881 std::vector<DataSenderInfo> senders; 879 std::vector<DataSenderInfo> senders;
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
1075 // The |ssrc| must correspond to a registered send stream. 1073 // The |ssrc| must correspond to a registered send stream.
1076 virtual bool SetVideoSend( 1074 virtual bool SetVideoSend(
1077 uint32_t ssrc, 1075 uint32_t ssrc,
1078 bool enable, 1076 bool enable,
1079 const VideoOptions* options, 1077 const VideoOptions* options,
1080 rtc::VideoSourceInterface<webrtc::VideoFrame>* source) = 0; 1078 rtc::VideoSourceInterface<webrtc::VideoFrame>* source) = 0;
1081 // Sets the sink object to be used for the specified stream. 1079 // Sets the sink object to be used for the specified stream.
1082 // If SSRC is 0, the sink is used for the 'default' stream. 1080 // If SSRC is 0, the sink is used for the 'default' stream.
1083 virtual bool SetSink(uint32_t ssrc, 1081 virtual bool SetSink(uint32_t ssrc,
1084 rtc::VideoSinkInterface<webrtc::VideoFrame>* sink) = 0; 1082 rtc::VideoSinkInterface<webrtc::VideoFrame>* sink) = 0;
1083 // This fills the "bitrate parts" (rtx, video bitrate) of the
1084 // BandwidthEstimationInfo, since that part that isn't possible to get
1085 // through webrtc::Call::GetStats, as they are statistics of the send
1086 // streams.
1087 // TODO(holmer): We should change this so that either BWE graphs doesn't
1088 // need access to bitrates of the streams, or change the (RTC)StatsCollector
1089 // so that it's getting the send stream stats separately by calling
1090 // GetStats(), and merges with BandwidthEstimationInfo by itself.
1091 virtual void FillBitrateInfo(BandwidthEstimationInfo* bwe_info) = 0;
1085 // Gets quality stats for the channel. 1092 // Gets quality stats for the channel.
1086 virtual bool GetStats(VideoMediaInfo* info) = 0; 1093 virtual bool GetStats(VideoMediaInfo* info) = 0;
1087 }; 1094 };
1088 1095
1089 enum DataMessageType { 1096 enum DataMessageType {
1090 // Chrome-Internal use only. See SctpDataMediaChannel for the actual PPID 1097 // Chrome-Internal use only. See SctpDataMediaChannel for the actual PPID
1091 // values. 1098 // values.
1092 DMT_NONE = 0, 1099 DMT_NONE = 0,
1093 DMT_CONTROL = 1, 1100 DMT_CONTROL = 1,
1094 DMT_BINARY = 2, 1101 DMT_BINARY = 2,
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
1204 const char*, 1211 const char*,
1205 size_t> SignalDataReceived; 1212 size_t> SignalDataReceived;
1206 // Signal when the media channel is ready to send the stream. Arguments are: 1213 // Signal when the media channel is ready to send the stream. Arguments are:
1207 // writable(bool) 1214 // writable(bool)
1208 sigslot::signal1<bool> SignalReadyToSend; 1215 sigslot::signal1<bool> SignalReadyToSend;
1209 }; 1216 };
1210 1217
1211 } // namespace cricket 1218 } // namespace cricket
1212 1219
1213 #endif // WEBRTC_MEDIA_BASE_MEDIACHANNEL_H_ 1220 #endif // WEBRTC_MEDIA_BASE_MEDIACHANNEL_H_
OLDNEW
« no previous file with comments | « webrtc/media/base/fakemediaengine.h ('k') | webrtc/media/engine/webrtcvideoengine2.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698