webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h - Issue 2862543002: Split iOS sdk in to separate targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h

Issue 2862543002: Split iOS sdk in to separate targets (Closed)

Patch Set: fix build for simulator Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/sdk/BUILD.gn ('K') | « webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc ('k') | webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMacros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h

diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h

index 65f593184479c7d83aa71d3f588b6071816faef2..faffcfa6c88a06aac7f91668632d697292dde737 100644

--- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h

+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h

@@ -45,7 +45,7 @@ RTC_EXPORT

@property(nonatomic, assign) int channelId;

/** Set by the application and opaque to the WebRTC implementation. */

-@property(nonatomic) NSString *protocol;

+@property(nonatomic, copy) NSString *protocol;

tkchin_webrtc 2017/05/15 22:45:10 why is this changed in this CL?

kthelgason 2017/05/16 07:57:13 I have no idea how this happened, thanks for spott

@end