Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: content/browser/download/download_request_core_unittest.cc

Issue 2860593003: Refactoring DownloadManager::DownloadURL to add proper annotation. (Closed)
Patch Set: Comment addressed. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "content/browser/download/download_item_impl.h" 9 #include "content/browser/download/download_item_impl.h"
10 #include "content/browser/download/download_request_core.h" 10 #include "content/browser/download/download_request_core.h"
11 #include "content/public/browser/browser_thread.h" 11 #include "content/public/browser/browser_thread.h"
12 #include "content/public/browser/download_url_parameters.h" 12 #include "content/public/browser/download_url_parameters.h"
13 #include "content/public/test/test_browser_thread_bundle.h" 13 #include "content/public/test/test_browser_thread_bundle.h"
14 #include "net/http/http_request_headers.h" 14 #include "net/http/http_request_headers.h"
15 #include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
15 #include "net/url_request/url_request_test_util.h" 16 #include "net/url_request/url_request_test_util.h"
16 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
17 18
18 namespace content { 19 namespace content {
19 20
20 namespace { 21 namespace {
21 22
22 const char kTestLastModifiedTime[] = "Tue, 15 Nov 1994 12:45:26 GMT"; 23 const char kTestLastModifiedTime[] = "Tue, 15 Nov 1994 12:45:26 GMT";
23 24
24 } // namespace 25 } // namespace
(...skipping 15 matching lines...) Expand all
40 EXPECT_EQ(expected_header_value, header_value); 41 EXPECT_EQ(expected_header_value, header_value);
41 } 42 }
42 43
43 bool HasRequestHeader(const std::string& name) { 44 bool HasRequestHeader(const std::string& name) {
44 DCHECK(url_request_.get()); 45 DCHECK(url_request_.get());
45 return url_request_->extra_request_headers().HasHeader(name); 46 return url_request_->extra_request_headers().HasHeader(name);
46 } 47 }
47 48
48 void CreateRequestOnIOThread(DownloadUrlParameters* params) { 49 void CreateRequestOnIOThread(DownloadUrlParameters* params) {
49 url_request_ = DownloadRequestCore::CreateRequestOnIOThread( 50 url_request_ = DownloadRequestCore::CreateRequestOnIOThread(
50 DownloadItem::kInvalidId, params); 51 DownloadItem::kInvalidId, params, TRAFFIC_ANNOTATION_FOR_TESTS);
51 DCHECK(url_request_.get()); 52 DCHECK(url_request_.get());
52 } 53 }
53 54
54 void SetUp() override { 55 void SetUp() override {
55 request_context_getter_ = new net::TestURLRequestContextGetter( 56 request_context_getter_ = new net::TestURLRequestContextGetter(
56 content::BrowserThread::GetTaskRunnerForThread( 57 content::BrowserThread::GetTaskRunnerForThread(
57 content::BrowserThread::UI)); 58 content::BrowserThread::UI));
58 } 59 }
59 60
60 void TearDown() override { 61 void TearDown() override {
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 CreateRequestOnIOThread(params.get()); 171 CreateRequestOnIOThread(params.get());
171 CheckRequestHeaders(net::HttpRequestHeaders::kRange, "bytes=50-"); 172 CheckRequestHeaders(net::HttpRequestHeaders::kRange, "bytes=50-");
172 CheckRequestHeaders(net::HttpRequestHeaders::kIfUnmodifiedSince, 173 CheckRequestHeaders(net::HttpRequestHeaders::kIfUnmodifiedSince,
173 kTestLastModifiedTime); 174 kTestLastModifiedTime);
174 EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfRange)); 175 EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfRange));
175 EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfMatch)); 176 EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfMatch));
176 url_request_.reset(); 177 url_request_.reset();
177 } 178 }
178 179
179 } // namespace content 180 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/download/download_request_core.cc ('k') | content/browser/download/download_worker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698