Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: webrtc/base/proxy_unittest.cc

Issue 2859373003: Refactor TestClient to use std::unique_ptr, and fix VirtualSocketServerTest leaks. (Closed)
Patch Set: git cl format Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/proxy_unittest.cc
diff --git a/webrtc/base/proxy_unittest.cc b/webrtc/base/proxy_unittest.cc
index b72d228ea0c644f00088001fd2b8938f135103de..631d91b605bea29141f352b78f2a3575d16f6632 100644
--- a/webrtc/base/proxy_unittest.cc
+++ b/webrtc/base/proxy_unittest.cc
@@ -61,10 +61,11 @@ TEST_F(ProxyTest, TestSocks5Connect) {
rtc::TestEchoServer server(Thread::Current(),
SocketAddress(INADDR_ANY, 0));
- rtc::AsyncTCPSocket* packet_socket = rtc::AsyncTCPSocket::Create(
- proxy_socket, SocketAddress(INADDR_ANY, 0), server.address());
+ std::unique_ptr<rtc::AsyncTCPSocket> packet_socket(
+ rtc::AsyncTCPSocket::Create(proxy_socket, SocketAddress(INADDR_ANY, 0),
+ server.address()));
EXPECT_TRUE(packet_socket != nullptr);
- rtc::TestClient client(packet_socket);
+ rtc::TestClient client(std::move(packet_socket));
EXPECT_EQ(Socket::CS_CONNECTING, proxy_socket->GetState());
EXPECT_TRUE(client.CheckConnected());

Powered by Google App Engine
This is Rietveld 408576698