Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc

Issue 2856063003: Replace AudioSendStream::Config with rtclog::StreamConfig. (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
332 for (size_t i = 0; i < parsed_config.rtp_extensions.size(); i++) { 332 for (size_t i = 0; i < parsed_config.rtp_extensions.size(); i++) {
333 EXPECT_EQ(config.rtp_extensions[i].uri, 333 EXPECT_EQ(config.rtp_extensions[i].uri,
334 parsed_config.rtp_extensions[i].uri); 334 parsed_config.rtp_extensions[i].uri);
335 EXPECT_EQ(config.rtp_extensions[i].id, parsed_config.rtp_extensions[i].id); 335 EXPECT_EQ(config.rtp_extensions[i].id, parsed_config.rtp_extensions[i].id);
336 } 336 }
337 } 337 }
338 338
339 void RtcEventLogTestHelper::VerifyAudioSendStreamConfig( 339 void RtcEventLogTestHelper::VerifyAudioSendStreamConfig(
340 const ParsedRtcEventLog& parsed_log, 340 const ParsedRtcEventLog& parsed_log,
341 size_t index, 341 size_t index,
342 const AudioSendStream::Config& config) { 342 const rtclog::StreamConfig& config) {
343 const rtclog::Event& event = parsed_log.events_[index]; 343 const rtclog::Event& event = parsed_log.events_[index];
344 ASSERT_TRUE(IsValidBasicEvent(event)); 344 ASSERT_TRUE(IsValidBasicEvent(event));
345 ASSERT_EQ(rtclog::Event::AUDIO_SENDER_CONFIG_EVENT, event.type()); 345 ASSERT_EQ(rtclog::Event::AUDIO_SENDER_CONFIG_EVENT, event.type());
346 const rtclog::AudioSendConfig& sender_config = event.audio_sender_config(); 346 const rtclog::AudioSendConfig& sender_config = event.audio_sender_config();
347 // Check SSRCs. 347 // Check SSRCs.
348 EXPECT_EQ(config.rtp.ssrc, sender_config.ssrc()); 348 EXPECT_EQ(config.local_ssrc, sender_config.ssrc());
349 // Check header extensions. 349 // Check header extensions.
350 ASSERT_EQ(static_cast<int>(config.rtp.extensions.size()), 350 ASSERT_EQ(static_cast<int>(config.rtp_extensions.size()),
351 sender_config.header_extensions_size()); 351 sender_config.header_extensions_size());
352 for (int i = 0; i < sender_config.header_extensions_size(); i++) { 352 for (int i = 0; i < sender_config.header_extensions_size(); i++) {
353 ASSERT_TRUE(sender_config.header_extensions(i).has_name()); 353 ASSERT_TRUE(sender_config.header_extensions(i).has_name());
354 ASSERT_TRUE(sender_config.header_extensions(i).has_id()); 354 ASSERT_TRUE(sender_config.header_extensions(i).has_id());
355 const std::string& name = sender_config.header_extensions(i).name(); 355 const std::string& name = sender_config.header_extensions(i).name();
356 int id = sender_config.header_extensions(i).id(); 356 int id = sender_config.header_extensions(i).id();
357 EXPECT_EQ(config.rtp.extensions[i].id, id); 357 EXPECT_EQ(config.rtp_extensions[i].id, id);
358 EXPECT_EQ(config.rtp.extensions[i].uri, name); 358 EXPECT_EQ(config.rtp_extensions[i].uri, name);
359 } 359 }
360 360
361 // Check consistency of the parser. 361 // Check consistency of the parser.
362 AudioSendStream::Config parsed_config(nullptr); 362 rtclog::StreamConfig parsed_config;
363 parsed_log.GetAudioSendConfig(index, &parsed_config); 363 parsed_log.GetAudioSendConfig(index, &parsed_config);
364 // Check SSRCs 364 VerifyStreamConfigsAreEqual(config, parsed_config);
365 EXPECT_EQ(config.rtp.ssrc, parsed_config.rtp.ssrc);
366 // Check header extensions.
367 EXPECT_EQ(config.rtp.extensions.size(), parsed_config.rtp.extensions.size());
368 for (size_t i = 0; i < parsed_config.rtp.extensions.size(); i++) {
369 EXPECT_EQ(config.rtp.extensions[i].uri,
370 parsed_config.rtp.extensions[i].uri);
371 EXPECT_EQ(config.rtp.extensions[i].id, parsed_config.rtp.extensions[i].id);
372 }
373 } 365 }
374 366
375 void RtcEventLogTestHelper::VerifyRtpEvent(const ParsedRtcEventLog& parsed_log, 367 void RtcEventLogTestHelper::VerifyRtpEvent(const ParsedRtcEventLog& parsed_log,
376 size_t index, 368 size_t index,
377 PacketDirection direction, 369 PacketDirection direction,
378 MediaType media_type, 370 MediaType media_type,
379 const uint8_t* header, 371 const uint8_t* header,
380 size_t header_size, 372 size_t header_size,
381 size_t total_size) { 373 size_t total_size) {
382 const rtclog::Event& event = parsed_log.events_[index]; 374 const rtclog::Event& event = parsed_log.events_[index];
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
598 ASSERT_TRUE(bwe_event.has_id()); 590 ASSERT_TRUE(bwe_event.has_id());
599 EXPECT_EQ(id, bwe_event.id()); 591 EXPECT_EQ(id, bwe_event.id());
600 ASSERT_TRUE(bwe_event.has_result()); 592 ASSERT_TRUE(bwe_event.has_result());
601 EXPECT_EQ(GetProbeResultType(failure_reason), bwe_event.result()); 593 EXPECT_EQ(GetProbeResultType(failure_reason), bwe_event.result());
602 ASSERT_FALSE(bwe_event.has_bitrate_bps()); 594 ASSERT_FALSE(bwe_event.has_bitrate_bps());
603 595
604 // TODO(philipel): Verify the parser when parsing has been implemented. 596 // TODO(philipel): Verify the parser when parsing has been implemented.
605 } 597 }
606 598
607 } // namespace webrtc 599 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.h ('k') | webrtc/tools/event_log_visualizer/analyzer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698