 Chromium Code Reviews
 Chromium Code Reviews Issue 2855023003:
  Move RTCAudioSession* files  modules/audio_device/ -> sdk/Framework.  (Closed)
    
  
    Issue 2855023003:
  Move RTCAudioSession* files  modules/audio_device/ -> sdk/Framework.  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 # Copyright 2016 The WebRTC project authors. All Rights Reserved. | 1 # Copyright 2016 The WebRTC project authors. All Rights Reserved. | 
| 2 # | 2 # | 
| 3 # Use of this source code is governed by a BSD-style license | 3 # Use of this source code is governed by a BSD-style license | 
| 4 # that can be found in the LICENSE file in the root of the source | 4 # that can be found in the LICENSE file in the root of the source | 
| 5 # tree. An additional intellectual property rights grant can be found | 5 # tree. An additional intellectual property rights grant can be found | 
| 6 # in the file PATENTS. All contributing project authors may | 6 # in the file PATENTS. All contributing project authors may | 
| 7 # be found in the AUTHORS file in the root of the source tree. | 7 # be found in the AUTHORS file in the root of the source tree. | 
| 8 | 8 | 
| 9 import("../webrtc.gni") | 9 import("../webrtc.gni") | 
| 10 if (is_ios) { | 10 if (is_ios) { | 
| (...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 73 | 73 | 
| 74 if (!build_with_chromium) { | 74 if (!build_with_chromium) { | 
| 75 sources += [ | 75 sources += [ | 
| 76 "objc/Framework/Classes/Common/RTCFileLogger.mm", | 76 "objc/Framework/Classes/Common/RTCFileLogger.mm", | 
| 77 "objc/Framework/Headers/WebRTC/RTCFileLogger.h", | 77 "objc/Framework/Headers/WebRTC/RTCFileLogger.h", | 
| 78 ] | 78 ] | 
| 79 } | 79 } | 
| 80 } | 80 } | 
| 81 | 81 | 
| 82 if (!build_with_chromium) { | 82 if (!build_with_chromium) { | 
| 83 rtc_static_library("objc_audio") { | |
| 84 sources = [ | |
| 85 "objc/Framework/Classes/RTCAudioSession+Configuration.mm", | |
| 86 "objc/Framework/Classes/RTCAudioSession+Private.h", | |
| 87 "objc/Framework/Classes/RTCAudioSession.mm", | |
| 88 "objc/Framework/Classes/RTCAudioSessionConfiguration.m", | |
| 
kthelgason
2017/06/02 13:54:06
Can you nest these in an "Audio" folder inside Cla
 
daniela-webrtc
2017/06/02 14:16:44
Done.
 | |
| 89 "objc/Framework/Headers/WebRTC/RTCAudioSession.h", | |
| 90 "objc/Framework/Headers/WebRTC/RTCAudioSessionConfiguration.h", | |
| 91 ] | |
| 92 configs += [ "..:common_objc" ] | |
| 93 | |
| 94 deps = [ | |
| 95 ":objc_common", | |
| 96 "../base:rtc_base_approved", | |
| 97 ] | |
| 98 | |
| 99 if (is_clang) { | |
| 100 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163) . | |
| 101 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] | |
| 102 } | |
| 103 } | |
| 83 rtc_static_library("objc_video") { | 104 rtc_static_library("objc_video") { | 
| 84 sources = [ | 105 sources = [ | 
| 85 "objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.h", | 106 "objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.h", | 
| 86 "objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.mm", | 107 "objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.mm", | 
| 87 "objc/Framework/Classes/Video/RTCDefaultShader.h", | 108 "objc/Framework/Classes/Video/RTCDefaultShader.h", | 
| 88 "objc/Framework/Classes/Video/RTCDefaultShader.mm", | 109 "objc/Framework/Classes/Video/RTCDefaultShader.mm", | 
| 89 "objc/Framework/Classes/Video/RTCI420TextureCache.h", | 110 "objc/Framework/Classes/Video/RTCI420TextureCache.h", | 
| 90 "objc/Framework/Classes/Video/RTCI420TextureCache.mm", | 111 "objc/Framework/Classes/Video/RTCI420TextureCache.mm", | 
| 91 "objc/Framework/Classes/Video/RTCOpenGLDefines.h", | 112 "objc/Framework/Classes/Video/RTCOpenGLDefines.h", | 
| 92 "objc/Framework/Classes/Video/RTCShader.h", | 113 "objc/Framework/Classes/Video/RTCShader.h", | 
| (...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 358 | 379 | 
| 359 defines = [ "GTEST_RELATIVE_PATH" ] | 380 defines = [ "GTEST_RELATIVE_PATH" ] | 
| 360 deps = [ | 381 deps = [ | 
| 361 ":objc_peerconnection", | 382 ":objc_peerconnection", | 
| 362 "..//system_wrappers:system_wrappers_default", | 383 "..//system_wrappers:system_wrappers_default", | 
| 363 "../base:rtc_base_tests_utils", | 384 "../base:rtc_base_tests_utils", | 
| 364 "../system_wrappers:system_wrappers_default", | 385 "../system_wrappers:system_wrappers_default", | 
| 365 "//third_party/ocmock", | 386 "//third_party/ocmock", | 
| 366 ] | 387 ] | 
| 367 | 388 | 
| 368 # RTCMTLVideoView not supported on 32-bit arm | 389 # RTCMTLVideoView not supported on 32-bit arm | 
| 
kthelgason
2017/06/02 13:54:06
This comment now needs to be moved inside the if(i
 
daniela-webrtc
2017/06/02 14:16:44
Done.
 | |
| 369 if (is_ios && current_cpu != "arm") { | 390 if (is_ios) { | 
| 370 sources += [ "objc/Framework/UnitTests/RTCMTLVideoViewTests.mm" ] | 391 sources += [ "objc/Framework/UnitTests/RTCAudioSessionTest.mm" ] | 
| 371 if (current_cpu != "arm64") { | 392 if (current_cpu != "arm") { | 
| 372 # Only include this file on simulator, as it's already | 393 sources += [ "objc/Framework/UnitTests/RTCMTLVideoViewTests.mm" ] | 
| 373 # included in device builds. | 394 if (current_cpu != "arm64") { | 
| 374 sources += [ "objc/Framework/Classes/Metal/RTCMTLVideoView.m" ] | 395 # Only include this file on simulator, as it's already | 
| 375 libs = [ "CoreVideo.framework" ] | 396 # included in device builds. | 
| 397 sources += [ "objc/Framework/Classes/Metal/RTCMTLVideoView.m" ] | |
| 398 libs = [ "CoreVideo.framework" ] | |
| 399 } | |
| 376 } | 400 } | 
| 377 } | 401 } | 
| 378 | |
| 379 if (!build_with_chromium && is_clang) { | 402 if (!build_with_chromium && is_clang) { | 
| 380 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/16 3). | 403 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/16 3). | 
| 381 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] | 404 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] | 
| 382 } | 405 } | 
| 383 } | 406 } | 
| 384 } | 407 } | 
| 385 | 408 | 
| 386 if (is_ios) { | 409 if (is_ios) { | 
| 387 ios_framework_bundle("objc_framework") { | 410 ios_framework_bundle("objc_framework") { | 
| 388 info_plist = "objc/Framework/Info.plist" | 411 info_plist = "objc/Framework/Info.plist" | 
| 389 output_name = "WebRTC" | 412 output_name = "WebRTC" | 
| 390 | 413 | 
| 391 common_objc_headers = [ | 414 common_objc_headers = [ | 
| 415 "objc/Framework/Headers/WebRTC/RTCAudioSession.h", | |
| 416 "objc/Framework/Headers/WebRTC/RTCAudioSessionConfiguration.h", | |
| 392 "objc/Framework/Headers/WebRTC/RTCAVFoundationVideoSource.h", | 417 "objc/Framework/Headers/WebRTC/RTCAVFoundationVideoSource.h", | 
| 393 "objc/Framework/Headers/WebRTC/RTCAudioSource.h", | 418 "objc/Framework/Headers/WebRTC/RTCAudioSource.h", | 
| 394 "objc/Framework/Headers/WebRTC/RTCAudioTrack.h", | 419 "objc/Framework/Headers/WebRTC/RTCAudioTrack.h", | 
| 395 "objc/Framework/Headers/WebRTC/RTCCameraVideoCapturer.h", | 420 "objc/Framework/Headers/WebRTC/RTCCameraVideoCapturer.h", | 
| 396 "objc/Framework/Headers/WebRTC/RTCCameraPreviewView.h", | 421 "objc/Framework/Headers/WebRTC/RTCCameraPreviewView.h", | 
| 397 "objc/Framework/Headers/WebRTC/RTCConfiguration.h", | 422 "objc/Framework/Headers/WebRTC/RTCConfiguration.h", | 
| 398 "objc/Framework/Headers/WebRTC/RTCDataChannel.h", | 423 "objc/Framework/Headers/WebRTC/RTCDataChannel.h", | 
| 399 "objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h", | 424 "objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h", | 
| 400 "objc/Framework/Headers/WebRTC/RTCDispatcher.h", | 425 "objc/Framework/Headers/WebRTC/RTCDispatcher.h", | 
| 401 "objc/Framework/Headers/WebRTC/RTCEAGLVideoView.h", | 426 "objc/Framework/Headers/WebRTC/RTCEAGLVideoView.h", | 
| (...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 442 public_headers += [ "objc/Framework/Headers/WebRTC/RTCFileLogger.h" ] | 467 public_headers += [ "objc/Framework/Headers/WebRTC/RTCFileLogger.h" ] | 
| 443 } | 468 } | 
| 444 | 469 | 
| 445 ldflags = [ | 470 ldflags = [ | 
| 446 "-all_load", | 471 "-all_load", | 
| 447 "-install_name", | 472 "-install_name", | 
| 448 "@rpath/$output_name.framework/$output_name", | 473 "@rpath/$output_name.framework/$output_name", | 
| 449 ] | 474 ] | 
| 450 | 475 | 
| 451 deps = [ | 476 deps = [ | 
| 477 ":objc_audio", | |
| 452 ":objc_peerconnection", | 478 ":objc_peerconnection", | 
| 453 ":objc_ui", | 479 ":objc_ui", | 
| 454 "../base:rtc_base_approved", | 480 "../base:rtc_base_approved", | 
| 455 "../system_wrappers:field_trial_default", | 481 "../system_wrappers:field_trial_default", | 
| 456 "../system_wrappers:metrics_default", | 482 "../system_wrappers:metrics_default", | 
| 457 ] | 483 ] | 
| 458 | 484 | 
| 459 libs = [ | 485 libs = [ | 
| 460 "AVFoundation.framework", | 486 "AVFoundation.framework", | 
| 461 "CoreGraphics.framework", | 487 "CoreGraphics.framework", | 
| (...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 550 public_deps = [ | 576 public_deps = [ | 
| 551 "$rtc_libyuv_dir", | 577 "$rtc_libyuv_dir", | 
| 552 ] | 578 ] | 
| 553 } else { | 579 } else { | 
| 554 # Need to add a directory normally exported by libyuv. | 580 # Need to add a directory normally exported by libyuv. | 
| 555 include_dirs = [ "$rtc_libyuv_dir/include" ] | 581 include_dirs = [ "$rtc_libyuv_dir/include" ] | 
| 556 } | 582 } | 
| 557 } | 583 } | 
| 558 } | 584 } | 
| 559 } | 585 } | 
| OLD | NEW |