webrtc/sdk/android/src/jni/androidvideotracksource.cc - Issue 2854123003: Build WebRTC with data channel only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/android/src/jni/androidvideotracksource.cc

Issue 2854123003: Build WebRTC with data channel only. (Closed)

Patch Set: Fix the issues. Make it ready for another round of review. Add a test. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/sdk/android/src/jni/androidvideotracksource.cc

diff --git a/webrtc/sdk/android/src/jni/androidvideotracksource.cc b/webrtc/sdk/android/src/jni/androidvideotracksource.cc

index 1a4a276ae218e1c0d6fb1313bd849eaac7a1ab9a..81ba965019043126fef44d6664f524945032c056 100644

--- a/webrtc/sdk/android/src/jni/androidvideotracksource.cc

+++ b/webrtc/sdk/android/src/jni/androidvideotracksource.cc

@@ -12,6 +12,8 @@

#include <utility>

+#include "webrtc/base/logging.h"

sakal 2017/05/23 09:33:19 Are these new includes needed?

Zhi Huang 2017/05/23 18:49:46 Yes. We use LOG(LS_...) in this file. We used to r

namespace {

// MediaCodec wants resolution to be divisible by 2.

const int kRequiredResolutionAlignment = 2;