webrtc/media/engine/webrtcvoiceengine.h - Issue 2854123003: Build WebRTC with data channel only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvoiceengine.h

Issue 2854123003: Build WebRTC with data channel only. (Closed)

Patch Set: Fix the issues. Make it ready for another round of review. Add a test. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/webrtcvoiceengine.h

diff --git a/webrtc/media/engine/webrtcvoiceengine.h b/webrtc/media/engine/webrtcvoiceengine.h

index d8466a0b414ace78f52236757e7324fd6d0b80ca..33d38fe26774b11c01549d59caa05e41131639b3 100644

--- a/webrtc/media/engine/webrtcvoiceengine.h

+++ b/webrtc/media/engine/webrtcvoiceengine.h

@@ -213,7 +213,7 @@ class WebRtcVoiceMediaChannel final : public VoiceMediaChannel,

uint32_t ssrc,

std::unique_ptr<webrtc::AudioSinkInterface> sink) override;

- std::vector<webrtc::RtpSource> GetSources(uint32_t ssrc) const;

+ std::vector<webrtc::RtpSource> GetSources(uint32_t ssrc) const override;

// implements Transport interface

bool SendRtp(const uint8_t* data,