Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log.h

Issue 2854123003: Build WebRTC with data channel only. (Closed)
Patch Set: Fix the issues. Make it ready for another round of review. Add a test. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log.h
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log.h b/webrtc/logging/rtc_event_log/rtc_event_log.h
index 3f96556d8a56c29905ac56b4417df204973f5d96..37bf203226be5df442321b5c0a0fe5882a97ba48 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log.h
+++ b/webrtc/logging/rtc_event_log/rtc_event_log.h
@@ -15,6 +15,7 @@
#include <string>
#include <vector>
+#include "webrtc/base/logging.h"
#include "webrtc/base/platform_file.h"
#include "webrtc/call/audio_receive_stream.h"
#include "webrtc/call/audio_send_stream.h"
@@ -195,7 +196,13 @@ class RtcEventLogNullImpl final : public RtcEventLog {
return false;
}
bool StartLogging(rtc::PlatformFile platform_file,
- int64_t max_size_bytes) override;
+ int64_t max_size_bytes) override {
+ // The platform_file is open and needs to be closed.
+ if (!rtc::ClosePlatformFile(platform_file)) {
+ LOG(LS_ERROR) << "Can't close file.";
+ }
+ return false;
+ }
void StopLogging() override {}
void LogVideoReceiveStreamConfig(
const rtclog::StreamConfig& config) override {}

Powered by Google App Engine
This is Rietveld 408576698