Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: webrtc/call/call.h

Issue 2854123003: Build WebRTC with data channel only. (Closed)
Patch Set: Merge. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/BUILD.gn ('k') | webrtc/call/call.cc » ('j') | webrtc/media/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call.h
diff --git a/webrtc/call/call.h b/webrtc/call/call.h
index caf0ee2d881951e5c28320086b6cf74c2c48ef92..75a9807af0f0ca414faf0e0dad7fd778863c455e 100644
--- a/webrtc/call/call.h
+++ b/webrtc/call/call.h
@@ -60,10 +60,16 @@ class Call {
public:
struct Config {
explicit Config(RtcEventLog* event_log) : event_log(event_log) {
+#ifdef HAVE_MEDIA
RTC_DCHECK(event_log);
+#endif
pthatcher1 2017/05/03 18:05:53 Would it be easier to just not include this file i
Zhi Huang 2017/05/04 01:08:02 This is the base class of internal::Call and this
}
+#ifdef HAVE_MEDIA
static const int kDefaultStartBitrateBps;
+#else
+ static const int kDefaultStartBitrateBps = -1;
pthatcher1 2017/05/03 18:05:53 It's confusing that we have an ifdef in two places
Zhi Huang 2017/05/04 01:08:02 This is because call.h is an abstract class and it
+#endif
// Bitrate config used until valid bitrate estimates are calculated. Also
// used to cap total bitrate used.
« no previous file with comments | « webrtc/BUILD.gn ('k') | webrtc/call/call.cc » ('j') | webrtc/media/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698