Build WebRTC with data channel only.

webrtc/pc/peerconnectionfactory.cc

Index: webrtc/pc/peerconnectionfactory.cc
diff --git a/webrtc/pc/peerconnectionfactory.cc b/webrtc/pc/peerconnectionfactory.cc
index 777bac1eb59aadd49bcc9af1d44ac66e9d02276f..20d8a7f05d39f6989ff016b8a02d780f05c19bc1 100644
--- a/webrtc/pc/peerconnectionfactory.cc
+++ b/webrtc/pc/peerconnectionfactory.cc
@@ -12,8 +12,6 @@
 
 #include <utility>
 
-#include "webrtc/api/audio_codecs/builtin_audio_decoder_factory.h"
-#include "webrtc/api/audio_codecs/builtin_audio_encoder_factory.h"
 #include "webrtc/api/mediaconstraintsinterface.h"
 #include "webrtc/api/mediastreamproxy.h"
 #include "webrtc/api/mediastreamtrackproxy.h"
@@ -22,10 +20,13 @@
 #include "webrtc/api/videosourceproxy.h"
 #include "webrtc/base/bind.h"
 #include "webrtc/base/checks.h"
-#include "webrtc/media/engine/webrtcmediaengine.h"
-#include "webrtc/media/engine/webrtcvideodecoderfactory.h"
-#include "webrtc/media/engine/webrtcvideoencoderfactory.h"
-#include "webrtc/modules/audio_device/include/audio_device.h"
+#include "webrtc/logging/rtc_event_log/rtc_event_log.h"
+// Adding 'nogncheck' to disable the gn include headers check to support modular
+// WebRTC build targets.
+#include "webrtc/media/engine/webrtcmediaengine.h"             // nogncheck
+#include "webrtc/media/engine/webrtcvideodecoderfactory.h"     // nogncheck
+#include "webrtc/media/engine/webrtcvideoencoderfactory.h"     // nogncheck
+#include "webrtc/modules/audio_device/include/audio_device.h"  // nogncheck
 #include "webrtc/p2p/base/basicpacketsocketfactory.h"
 #include "webrtc/p2p/client/basicportallocator.h"
 #include "webrtc/pc/audiotrack.h"
@@ -38,26 +39,15 @@
 namespace webrtc {
 
 rtc::scoped_refptr<PeerConnectionFactoryInterface> CreatePeerConnectionFactory(

[the sun, 2017/06/12 20:58:41]

Does this need to be here? I find it odd that it calls a function defined in
createpeerconnectionfactory.cc

[Zhi Huang, 2017/06/12 22:18:58]

I'll move these impl to  createpeerconnectionfactory.cc.

-    rtc::scoped_refptr<AudioEncoderFactory> audio_encoder_factory,
-    rtc::scoped_refptr<AudioDecoderFactory> audio_decoder_factory) {
-  rtc::scoped_refptr<PeerConnectionFactory> pc_factory(
-      new rtc::RefCountedObject<PeerConnectionFactory>(audio_encoder_factory,
-                                                       audio_decoder_factory));
-
-  RTC_CHECK(rtc::Thread::Current() == pc_factory->signaling_thread());
-  // The signaling thread is the current thread so we can
-  // safely call Initialize directly.
-  if (!pc_factory->Initialize()) {
-    return nullptr;
-  }
-  return PeerConnectionFactoryProxy::Create(pc_factory->signaling_thread(),
-                                            pc_factory);
-}
-
-rtc::scoped_refptr<PeerConnectionFactoryInterface>
-CreatePeerConnectionFactory() {
-  return CreatePeerConnectionFactory(CreateBuiltinAudioEncoderFactory(),
-                                     CreateBuiltinAudioDecoderFactory());
+    rtc::Thread* network_thread,
+    rtc::Thread* worker_thread,
+    rtc::Thread* signaling_thread,
+    AudioDeviceModule* default_adm,
+    cricket::WebRtcVideoEncoderFactory* encoder_factory,
+    cricket::WebRtcVideoDecoderFactory* decoder_factory) {
+  return CreatePeerConnectionFactoryWithAudioMixer(
+      network_thread, worker_thread, signaling_thread, default_adm,
+      encoder_factory, decoder_factory, nullptr);
 }
 
 rtc::scoped_refptr<PeerConnectionFactoryInterface> CreatePeerConnectionFactory(
@@ -75,20 +65,32 @@ rtc::scoped_refptr<PeerConnectionFactoryInterface> CreatePeerConnectionFactory(
       video_decoder_factory, nullptr);
 }
 
-rtc::scoped_refptr<PeerConnectionFactoryInterface> CreatePeerConnectionFactory(
-    rtc::Thread* network_thread,
+rtc::scoped_refptr<PeerConnectionFactoryInterface>
+CreateModularPeerConnectionFactory(
     rtc::Thread* worker_thread,
-    rtc::Thread* signaling_thread,
-    AudioDeviceModule* default_adm,
-    cricket::WebRtcVideoEncoderFactory* encoder_factory,
-    cricket::WebRtcVideoDecoderFactory* decoder_factory) {
-  return CreatePeerConnectionFactoryWithAudioMixer(
-      network_thread, worker_thread, signaling_thread, default_adm,
-      encoder_factory, decoder_factory, nullptr);
+    rtc::scoped_refptr<AudioEncoderFactory> audio_encoder_factory,
+    rtc::scoped_refptr<AudioDecoderFactory> audio_decoder_factory,
+    std::unique_ptr<cricket::MediaEngineInterface> media_engine,
+    std::unique_ptr<CallFactoryInterface> call_factory,
+    std::unique_ptr<RtcEventLogFactoryInterface> event_log_factory) {
+  rtc::scoped_refptr<PeerConnectionFactory> pc_factory(
+      new rtc::RefCountedObject<PeerConnectionFactory>(
+          worker_thread, audio_encoder_factory, audio_decoder_factory,
+          std::move(media_engine), std::move(call_factory),
+          std::move(event_log_factory)));
+
+  RTC_CHECK(rtc::Thread::Current() == pc_factory->signaling_thread());
+  // The signaling thread is the current thread so we can
+  // safely call Initialize directly.
+  if (!pc_factory->Initialize()) {
+    return nullptr;
+  }
+  return PeerConnectionFactoryProxy::Create(pc_factory->signaling_thread(),
+                                            pc_factory);
 }
 
 rtc::scoped_refptr<PeerConnectionFactoryInterface>
-CreatePeerConnectionFactoryWithAudioMixer(
+CreateModularPeerConnectionFactory(
     rtc::Thread* network_thread,
     rtc::Thread* worker_thread,
     rtc::Thread* signaling_thread,
@@ -97,12 +99,16 @@ CreatePeerConnectionFactoryWithAudioMixer(
     rtc::scoped_refptr<AudioDecoderFactory> audio_decoder_factory,
     cricket::WebRtcVideoEncoderFactory* video_encoder_factory,
     cricket::WebRtcVideoDecoderFactory* video_decoder_factory,
-    rtc::scoped_refptr<AudioMixer> audio_mixer) {
+    rtc::scoped_refptr<AudioMixer> audio_mixer,
+    std::unique_ptr<cricket::MediaEngineInterface> media_engine,
+    std::unique_ptr<CallFactoryInterface> call_factory,
+    std::unique_ptr<RtcEventLogFactoryInterface> event_log_factory) {
   rtc::scoped_refptr<PeerConnectionFactory> pc_factory(
       new rtc::RefCountedObject<PeerConnectionFactory>(
           network_thread, worker_thread, signaling_thread, default_adm,
           audio_encoder_factory, audio_decoder_factory, video_encoder_factory,
-          video_decoder_factory, audio_mixer));
+          video_decoder_factory, audio_mixer, std::move(media_engine),
+          std::move(call_factory), std::move(event_log_factory)));
 
   // Call Initialize synchronously but make sure it is executed on
   // |signaling_thread|.
@@ -116,37 +122,40 @@ CreatePeerConnectionFactoryWithAudioMixer(
   return PeerConnectionFactoryProxy::Create(signaling_thread, pc_factory);
 }
 
-rtc::scoped_refptr<PeerConnectionFactoryInterface>
-CreatePeerConnectionFactoryWithAudioMixer(
-    rtc::Thread* network_thread,
-    rtc::Thread* worker_thread,
-    rtc::Thread* signaling_thread,
-    AudioDeviceModule* default_adm,
-    cricket::WebRtcVideoEncoderFactory* encoder_factory,
-    cricket::WebRtcVideoDecoderFactory* decoder_factory,
-    rtc::scoped_refptr<AudioMixer> audio_mixer) {
-  return CreatePeerConnectionFactoryWithAudioMixer(
-      network_thread, worker_thread, signaling_thread, default_adm,
-      CreateBuiltinAudioEncoderFactory(), CreateBuiltinAudioDecoderFactory(),
-      encoder_factory, decoder_factory, audio_mixer);
+PeerConnectionFactory::PeerConnectionFactory(
+    rtc::scoped_refptr<webrtc::AudioEncoderFactory> audio_encoder_factory,
+    rtc::scoped_refptr<webrtc::AudioDecoderFactory> audio_decoder_factory)
+    : PeerConnectionFactory(rtc::Thread::Create().release(),
+                            audio_encoder_factory,
+                            audio_decoder_factory,
+                            std::unique_ptr<cricket::MediaEngineInterface>(),
+                            std::unique_ptr<webrtc::CallFactoryInterface>(),
+                            std::unique_ptr<RtcEventLogFactoryInterface>()) {
+  worker_thread_->Start();
 }
 
 PeerConnectionFactory::PeerConnectionFactory(
+    rtc::Thread* worker_thread,
     rtc::scoped_refptr<webrtc::AudioEncoderFactory> audio_encoder_factory,
-    rtc::scoped_refptr<webrtc::AudioDecoderFactory> audio_decoder_factory)
+    rtc::scoped_refptr<webrtc::AudioDecoderFactory> audio_decoder_factory,
+    std::unique_ptr<cricket::MediaEngineInterface> media_engine,
+    std::unique_ptr<webrtc::CallFactoryInterface> call_factory,
+    std::unique_ptr<RtcEventLogFactoryInterface> event_log_factory)
     : owns_ptrs_(true),
       wraps_current_thread_(false),
       network_thread_(rtc::Thread::CreateWithSocketServer().release()),
-      worker_thread_(rtc::Thread::Create().release()),
+      worker_thread_(worker_thread),
       signaling_thread_(rtc::Thread::Current()),
       audio_encoder_factory_(audio_encoder_factory),
-      audio_decoder_factory_(audio_decoder_factory) {
+      audio_decoder_factory_(audio_decoder_factory),
+      media_engine_(std::move(media_engine)),
+      call_factory_(std::move(call_factory)),
+      event_log_factory_(std::move(event_log_factory)) {
   if (!signaling_thread_) {
     signaling_thread_ = rtc::ThreadManager::Instance()->WrapCurrentThread();
     wraps_current_thread_ = true;
   }
   network_thread_->Start();
-  worker_thread_->Start();
 }
 
 PeerConnectionFactory::PeerConnectionFactory(
@@ -159,6 +168,32 @@ PeerConnectionFactory::PeerConnectionFactory(
     cricket::WebRtcVideoEncoderFactory* video_encoder_factory,
     cricket::WebRtcVideoDecoderFactory* video_decoder_factory,
     rtc::scoped_refptr<AudioMixer> audio_mixer)
+    : PeerConnectionFactory(network_thread,
+                            worker_thread,
+                            signaling_thread,
+                            default_adm,
+                            audio_encoder_factory,
+                            audio_decoder_factory,
+                            video_encoder_factory,
+                            video_decoder_factory,
+                            audio_mixer,
+                            std::unique_ptr<cricket::MediaEngineInterface>(),
+                            std::unique_ptr<webrtc::CallFactoryInterface>(),
+                            std::unique_ptr<RtcEventLogFactoryInterface>()) {}
+
+PeerConnectionFactory::PeerConnectionFactory(
+    rtc::Thread* network_thread,
+    rtc::Thread* worker_thread,
+    rtc::Thread* signaling_thread,
+    AudioDeviceModule* default_adm,
+    rtc::scoped_refptr<webrtc::AudioEncoderFactory> audio_encoder_factory,
+    rtc::scoped_refptr<webrtc::AudioDecoderFactory> audio_decoder_factory,
+    cricket::WebRtcVideoEncoderFactory* video_encoder_factory,
+    cricket::WebRtcVideoDecoderFactory* video_decoder_factory,
+    rtc::scoped_refptr<AudioMixer> audio_mixer,
+    std::unique_ptr<cricket::MediaEngineInterface> media_engine,
+    std::unique_ptr<webrtc::CallFactoryInterface> call_factory,
+    std::unique_ptr<RtcEventLogFactoryInterface> event_log_factory)
     : owns_ptrs_(false),
       wraps_current_thread_(false),
       network_thread_(network_thread),
@@ -169,7 +204,10 @@ PeerConnectionFactory::PeerConnectionFactory(
       audio_decoder_factory_(audio_decoder_factory),
       video_encoder_factory_(video_encoder_factory),
       video_decoder_factory_(video_decoder_factory),
-      external_audio_mixer_(audio_mixer) {
+      external_audio_mixer_(audio_mixer),
+      media_engine_(std::move(media_engine)),
+      call_factory_(std::move(call_factory)),
+      event_log_factory_(std::move(event_log_factory)) {
   RTC_DCHECK(network_thread);
   RTC_DCHECK(worker_thread);
   RTC_DCHECK(signaling_thread);
@@ -210,13 +248,8 @@ bool PeerConnectionFactory::Initialize() {
     return false;
   }
 
-  std::unique_ptr<cricket::MediaEngineInterface> media_engine =
-      worker_thread_->Invoke<std::unique_ptr<cricket::MediaEngineInterface>>(
-          RTC_FROM_HERE,
-          rtc::Bind(&PeerConnectionFactory::CreateMediaEngine_w, this));
-
   channel_manager_.reset(new cricket::ChannelManager(
-      std::move(media_engine), worker_thread_, network_thread_));
+      std::move(media_engine_), worker_thread_, network_thread_));
 
   channel_manager_->SetVideoRtxEnabled(true);
   if (!channel_manager_->Init()) {
@@ -320,8 +353,18 @@ PeerConnectionFactory::CreatePeerConnection(
       RTC_FROM_HERE, rtc::Bind(&cricket::PortAllocator::SetNetworkIgnoreMask,
                                allocator.get(), options_.network_ignore_mask));
 
+  std::unique_ptr<RtcEventLog> event_log(new RtcEventLogNullImpl());

[the sun, 2017/06/12 20:58:41]

Could you send in the event log directly instead of the factory? A client not
wanting it would call "new RtcEventLogNullImpl()" in their CreatePCF call.

[Zhi Huang, 2017/06/12 22:18:58]

I think the peerconnectionfactory need a RtcEventLogFactory because each
PeerConnection need their own RtcEventLog object. Same reason for having a
CallFactory there.

+  if (event_log_factory_) {
+    event_log = event_log_factory_->CreateRtcEventLog();
+  }
+
+  Call* call = worker_thread_->Invoke<Call*>(
+      RTC_FROM_HERE,
+      rtc::Bind(&PeerConnectionFactory::CreateCall_w, this, event_log.get()));
+
   rtc::scoped_refptr<PeerConnection> pc(
-      new rtc::RefCountedObject<PeerConnection>(this));
+      new rtc::RefCountedObject<PeerConnection>(this, std::move(event_log),
+                                                call));
 
   if (!pc->Initialize(configuration, std::move(allocator),
                       std::move(cert_generator), observer)) {
@@ -382,15 +425,21 @@ rtc::Thread* PeerConnectionFactory::network_thread() {
   return network_thread_;
 }
 
-std::unique_ptr<cricket::MediaEngineInterface>
-PeerConnectionFactory::CreateMediaEngine_w() {
-  RTC_DCHECK(worker_thread_ == rtc::Thread::Current());
-  return std::unique_ptr<cricket::MediaEngineInterface>(
-      cricket::WebRtcMediaEngineFactory::Create(
-          default_adm_.get(), audio_encoder_factory_,
-          audio_decoder_factory_,
-          video_encoder_factory_.get(), video_decoder_factory_.get(),
-          external_audio_mixer_));
+Call* PeerConnectionFactory::CreateCall_w(RtcEventLog* event_log) {
+  const int kMinBandwidthBps = 30000;
+  const int kStartBandwidthBps = 300000;
+  const int kMaxBandwidthBps = 2000000;
+
+  webrtc::Call::Config call_config(event_log);
+  if (!channel_manager_->media_engine() || !call_factory_) {
+    return nullptr;
+  }
+  call_config.audio_state = channel_manager_->media_engine()->GetAudioState();
+  call_config.bitrate_config.min_bitrate_bps = kMinBandwidthBps;
+  call_config.bitrate_config.start_bitrate_bps = kStartBandwidthBps;
+  call_config.bitrate_config.max_bitrate_bps = kMaxBandwidthBps;
+
+  return call_factory_->CreateCall(call_config);
 }
 
 }  // namespace webrtc