NetEqTest: Extend the callback structure

webrtc/modules/audio_coding/neteq/tools/neteq_test.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 19 matching lines @@
                                    const NetEqInput::PacketData& packet) {}
   virtual void OnGetAudioError(int error_code) {}
 };
 
 class DefaultNetEqTestErrorCallback : public NetEqTestErrorCallback {
   void OnInsertPacketError(int error_code,
                            const NetEqInput::PacketData& packet) override;
   void OnGetAudioError(int error_code) override;
 };
 
+class NetEqPostInsertPacket {
+ public:
+  virtual ~NetEqPostInsertPacket() = default;
+  virtual void AfterInsertPacket(const NetEqInput::PacketData& packet,

[ivoc, 2017/05/02 11:31:42]

Why no BeforeInsertPacket? Not useful?

[hlundin-webrtc, 2017/05/04 12:50:07]

Not at the moment. Easy enough to add if needed.

+                                 NetEq* neteq) = 0;

[ivoc, 2017/05/02 11:31:42]

Shouldn't this be a const reference as well? Or is it expected that the NetEq
will be changed during the callback?

[hlundin-webrtc, 2017/05/04 12:50:07]

The callback object may want to poll NetEq for statistics, which is a non-const
operation.

+};
+
+class NetEqGetAudioCallback {
+ public:
+  virtual ~NetEqGetAudioCallback() = default;
+  virtual void BeforeGetAudio(NetEq* neteq) = 0;
+  virtual void AfterGetAudio(int64_t time_now_ms,
+                             const AudioFrame& audio_frame,
+                             bool muted,
+                             NetEq* neteq) = 0;
+};
+
 // Class that provides an input--output test for NetEq. The input (both packets
 // and output events) is provided by a NetEqInput object, while the output is
 // directed to an AudioSink object.
 class NetEqTest {
  public:
   using DecoderMap = std::map<int, std::pair<NetEqDecoder, std::string> >;
 
   struct ExternalDecoderInfo {
     AudioDecoder* decoder;
     NetEqDecoder codec;
     std::string codec_name;
   };
 
   using ExtDecoderMap = std::map<int, ExternalDecoderInfo>;
 
+  struct Callbacks {
+    NetEqTestErrorCallback* error_callback = nullptr;
+    NetEqPostInsertPacket* post_insert_packet = nullptr;
+    NetEqGetAudioCallback* get_audio_callback = nullptr;
+  };
+
   // Sets up the test with given configuration, codec mappings, input, ouput,
   // and callback objects for error reporting.
   NetEqTest(const NetEq::Config& config,
             const DecoderMap& codecs,
             const ExtDecoderMap& ext_codecs,
             std::unique_ptr<NetEqInput> input,
             std::unique_ptr<AudioSink> output,
-            NetEqTestErrorCallback* error_callback);
+            Callbacks callbacks);

[AleBzk, 2017/05/02 10:36:55]

Copying callbacks is fine because it's just 3 pointers, right?

[hlundin-webrtc, 2017/05/04 12:50:07]

Yes.

 
   ~NetEqTest() = default;
 
   // Runs the test. Returns the duration of the produced audio in ms.
   int64_t Run();
 
   // Returns the statistics from NetEq.
   NetEqNetworkStatistics SimulationStats();
 
  private:
   void RegisterDecoders(const DecoderMap& codecs);
   void RegisterExternalDecoders(const ExtDecoderMap& codecs);
 
   std::unique_ptr<NetEq> neteq_;
   std::unique_ptr<NetEqInput> input_;
   std::unique_ptr<AudioSink> output_;
-  NetEqTestErrorCallback* error_callback_ = nullptr;
+  Callbacks callbacks_;
   int sample_rate_hz_;
 };
 
 }  // namespace test
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_NETEQ_TEST_H_