Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log.h

Issue 2850793002: Replace VideoReceiveStream::Config with new rtclog::StreamConfig in RtcEventLog. (Closed)
Patch Set: Fix merge. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log.h
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log.h b/webrtc/logging/rtc_event_log/rtc_event_log.h
index a98c71b75e24fe5987d5b88e86d2b11afb7cd413..d3e62130fa8106863692d437e5011d0a72ff0579 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log.h
+++ b/webrtc/logging/rtc_event_log/rtc_event_log.h
@@ -13,6 +13,7 @@
#include <memory>
#include <string>
+#include <vector>
#include "webrtc/base/platform_file.h"
#include "webrtc/call/audio_receive_stream.h"
@@ -26,6 +27,33 @@ namespace webrtc {
// the protobuf file.
namespace rtclog {
class EventStream;
+
+struct StreamConfig {
+ uint32_t local_ssrc = 0;
+ uint32_t remote_ssrc = 0;
+ uint32_t rtx_ssrc = 0;
+ std::string rsid;
+
+ bool remb = false;
+ std::vector<RtpExtension> rtp_extensions;
+
+ RtcpMode rtcp_mode = RtcpMode::kReducedSize;
+
+ struct Codec {
+ Codec(const std::string& payload_name,
+ int payload_type,
+ int rtx_payload_type)
+ : payload_name(payload_name),
+ payload_type(payload_type),
+ rtx_payload_type(rtx_payload_type) {}
+
+ std::string payload_name;
+ int payload_type;
+ int rtx_payload_type;
+ };
+ std::vector<Codec> codecs;
+};
+
} // namespace rtclog
class Clock;
@@ -84,9 +112,9 @@ class RtcEventLog {
// Stops logging to file and waits until the thread has finished.
virtual void StopLogging() = 0;
- // Logs configuration information for webrtc::VideoReceiveStream.
+ // Logs configuration information for video receive stream.
virtual void LogVideoReceiveStreamConfig(
- const webrtc::VideoReceiveStream::Config& config) = 0;
+ const rtclog::StreamConfig& config) = 0;
// Logs configuration information for webrtc::VideoSendStream.
virtual void LogVideoSendStreamConfig(
@@ -172,7 +200,7 @@ class RtcEventLogNullImpl final : public RtcEventLog {
int64_t max_size_bytes) override;
void StopLogging() override {}
void LogVideoReceiveStreamConfig(
- const VideoReceiveStream::Config& config) override {}
+ const rtclog::StreamConfig& config) override {}
void LogVideoSendStreamConfig(
const VideoSendStream::Config& config) override {}
void LogAudioReceiveStreamConfig(
« no previous file with comments | « webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h ('k') | webrtc/logging/rtc_event_log/rtc_event_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698