AGC2 as a new APM sub-module operating with hard-coded gain.

webrtc/modules/audio_processing/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/arm.gni")
 import("//third_party/protobuf/proto_library.gni")
@@ skipping 90 matching lines @@
     "aecm/echo_control_mobile.h",
     "agc/agc.cc",
     "agc/agc.h",
     "agc/agc_manager_direct.cc",
     "agc/agc_manager_direct.h",
     "agc/gain_map_internal.h",
     "agc/loudness_histogram.cc",
     "agc/loudness_histogram.h",
     "agc/utility.cc",
     "agc/utility.h",
+    "agc2/agc2.h",
+    "agc2/agc2_impl.cc",
+    "agc2/agc2_impl.h",

[aleloi, 2017/05/02 10:11:53]

I wonder how difficult it would be to write new submodules as separate build
targets. Or maybe split the audio_processing target up as part of our work.
Putting the build files in a subdirectory would simplify this file.

[AleBzk, 2017/05/02 11:31:54]

Personally, I like your idea a lot. I'll do this change since we have everything
in agc2/.

[aleloi, 2017/05/18 15:01:17]

Did you decide to keep everythnig in ':audio_processing'?

[peah-webrtc, 2017/05/18 20:17:52]

I think the build target idea sounds great as well. But I'm also ok with keeping
everything in audio_processing.

[AleBzk, 2017/05/19 13:15:41]

Let's make another CL for this.

     "audio_buffer.cc",
     "audio_buffer.h",
     "audio_processing_impl.cc",
     "audio_processing_impl.h",
     "beamformer/array_util.cc",
     "beamformer/array_util.h",
     "beamformer/complex_matrix.h",
     "beamformer/covariance_matrix_generator.cc",
     "beamformer/covariance_matrix_generator.h",
     "beamformer/matrix.h",
@@ skipping 371 matching lines @@
     # cover (which would be confusing to read and hard to maintain).
     if (!is_android && !is_ios) {
       visibility = [ "//webrtc/modules:modules_unittests" ]
     }
     sources = [
       "aec/echo_cancellation_unittest.cc",
       "aec/system_delay_unittest.cc",
       "agc/agc_manager_direct_unittest.cc",
       "agc/loudness_histogram_unittest.cc",
       "agc/mock_agc.h",
+      "agc2/agc2_mock.h",

[aleloi, 2017/05/02 10:11:53]

Same for tests. New module unittests could have a separate target, on which this
target depends.

[AleBzk, 2017/05/02 11:31:54]

Yup.

+      "agc2/agc2_unittest.cc",
       "audio_buffer_unittest.cc",
       "beamformer/array_util_unittest.cc",
       "beamformer/complex_matrix_unittest.cc",
       "beamformer/covariance_matrix_generator_unittest.cc",
       "beamformer/matrix_unittest.cc",
       "beamformer/mock_nonlinear_beamformer.h",
       "config_unittest.cc",
       "echo_cancellation_impl_unittest.cc",
       "splitting_filter_unittest.cc",
       "transient/dyadic_decimator_unittest.cc",
@@ skipping 329 matching lines @@
 
       deps = [
         ":audioproc_debug_proto",
         "../..:webrtc_common",
         "../../base:protobuf_utils",
         "../../base:rtc_base_approved",
       ]
     }
   }
 }