Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: webrtc/common_video/include/video_frame_buffer.h

Issue 2847383002: Add support for multiple pixel formats in VideoFrameBuffer (Closed)
Patch Set: Add common interface for I420 and I444 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/common_video/include/video_frame_buffer.h
diff --git a/webrtc/common_video/include/video_frame_buffer.h b/webrtc/common_video/include/video_frame_buffer.h
index dfdd480b5dc48b2a341669dcdc289f596195e54c..df47d2fbd13a7024d9eb14b18ee5cec15e2cf90c 100644
--- a/webrtc/common_video/include/video_frame_buffer.h
+++ b/webrtc/common_video/include/video_frame_buffer.h
@@ -30,6 +30,7 @@ class NativeHandleBuffer : public VideoFrameBuffer {
public:
NativeHandleBuffer(void* native_handle, int width, int height);
+ PixelFormat Format() const override;
int width() const override;
int height() const override;
const uint8_t* DataY() const override;
@@ -47,7 +48,7 @@ class NativeHandleBuffer : public VideoFrameBuffer {
const int height_;
};
-class WrappedI420Buffer : public webrtc::VideoFrameBuffer {
+class WrappedI420Buffer : public PlanarYuvBuffer {
public:
WrappedI420Buffer(int width,
int height,
@@ -58,6 +59,8 @@ class WrappedI420Buffer : public webrtc::VideoFrameBuffer {
const uint8_t* v_plane,
int v_stride,
const rtc::Callback0<void>& no_longer_used);
+ PixelFormat Format() const override;
+
int width() const override;
int height() const override;
@@ -68,10 +71,6 @@ class WrappedI420Buffer : public webrtc::VideoFrameBuffer {
int StrideU() const override;
int StrideV() const override;
- void* native_handle() const override;
-
- rtc::scoped_refptr<VideoFrameBuffer> NativeToI420Buffer() override;
-
private:
friend class rtc::RefCountedObject<WrappedI420Buffer>;
~WrappedI420Buffer() override;

Powered by Google App Engine
This is Rietveld 408576698