Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: webrtc/api/video/i420_buffer.h

Issue 2847383002: Add support for multiple pixel formats in VideoFrameBuffer (Closed)
Patch Set: Add common interface for I420 and I444 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/video/i420_buffer.h
diff --git a/webrtc/api/video/i420_buffer.h b/webrtc/api/video/i420_buffer.h
index 388a3dd76903ad9e8f24a7d841f6220c2d994a21..7915a9b3afd4255399e102ed46af2fb565acaf97 100644
--- a/webrtc/api/video/i420_buffer.h
+++ b/webrtc/api/video/i420_buffer.h
@@ -20,7 +20,7 @@
namespace webrtc {
// Plain I420 buffer in standard memory.
-class I420Buffer : public VideoFrameBuffer {
+class I420Buffer : public PlanarYuvBuffer {
public:
static rtc::scoped_refptr<I420Buffer> Create(int width, int height);
static rtc::scoped_refptr<I420Buffer> Create(int width,
@@ -53,9 +53,7 @@ class I420Buffer : public VideoFrameBuffer {
// are resolved in a better way. Or in the mean time, use SetBlack.
void InitializeData();
- // TODO(nisse): Deprecated, use static method instead.
nisse-webrtc 2017/05/04 08:15:29 Also deleted in cl https://codereview.webrtc.org/2
magjed_webrtc 2017/05/04 12:25:13 Wops, this is a mistake from rebasing. I'm trying
- void SetToBlack() { SetBlack(this); }
-
+ PixelFormat Format() const override;
int width() const override;
int height() const override;
const uint8_t* DataY() const override;
@@ -66,9 +64,6 @@ class I420Buffer : public VideoFrameBuffer {
int StrideU() const override;
int StrideV() const override;
- void* native_handle() const override;
- rtc::scoped_refptr<VideoFrameBuffer> NativeToI420Buffer() override;
-
uint8_t* MutableDataY();
uint8_t* MutableDataU();
uint8_t* MutableDataV();

Powered by Google App Engine
This is Rietveld 408576698