DesktopRect::UnionWith() to extend current rect to cover the input rect

webrtc/modules/desktop_capture/desktop_geometry.h

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 106 matching lines @@
 
   // Returns true if |point| lies within the rectangle boundaries.
   bool Contains(const DesktopVector& point) const;
 
   // Returns true if |rect| lies within the boundaries of this rectangle.
   bool ContainsRect(const DesktopRect& rect) const;
 
   // Finds intersection with |rect|.
   void IntersectWith(const DesktopRect& rect);
 
+  // Finds the minimum area to cover both |this| and |rect|. If |this| is empty,

[Sergey Ulanov, 2017/05/16 19:53:00]

It's not clear from this comment that the result is stored in the same object.
Maybe reword the first sentence as "Extends the rectangle to cover |rect|."

[Hzj_jie, 2017/05/16 23:04:18]

Done.

+  // replaces |this| with |rect|; if |rect| is empty, this function takes no
+  // effect.
+  void UnionWith(const DesktopRect& rect);
+
   // Adds (dx, dy) to the position of the rectangle.
   void Translate(int32_t dx, int32_t dy);
   void Translate(DesktopVector d) { Translate(d.x(), d.y()); };
 
   // Enlarges current DesktopRect by subtracting |left_offset| and |top_offset|
   // from |left_| and |top_|, and adding |right_offset| and |bottom_offset| to
   // |right_| and |bottom_|. This function does not normalize the result, so
   // |left_| and |top_| may be less than zero or larger than |right_| and
   // |bottom_|.
   void Extend(int32_t left_offset,
               int32_t top_offset,
               int32_t right_offset,
               int32_t bottom_offset);
 
  private:
   DesktopRect(int32_t left, int32_t top, int32_t right, int32_t bottom)
       : left_(left), top_(top), right_(right), bottom_(bottom) {
   }
 
   int32_t left_;
   int32_t top_;
   int32_t right_;
   int32_t bottom_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_DESKTOP_CAPTURE_DESKTOP_GEOMETRY_H_