Delete media type check in Call::NotifyBweOfReceivedPacket.

webrtc/pc/rtcstats_integrationtest.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 121 matching lines @@
   }
 
   void TestMemberIsUndefined(const RTCStatsMemberInterface& member) {
     EXPECT_FALSE(member.is_defined()) <<
         stats_->type() << "." << member.name() << "[" << stats_->id() <<
         "] was defined (" << member.ValueToString() << ").";
     MarkMemberTested(member, !member.is_defined());
   }
 
   template<typename T>
+  void TestMemberIsUndefinedOrNonNegative(
+      const RTCStatsMemberInterface& member) {
+    if (member.is_defined())
+      TestMemberIsNonNegative<T>(member);
+    else
+      MarkMemberTested(member, true);
+  }
+
+  template<typename T>
   void TestMemberIsPositive(const RTCStatsMemberInterface& member) {
     EXPECT_TRUE(member.is_defined()) <<
         stats_->type() << "." << member.name() << "[" << stats_->id() <<
         "] was undefined.";
     if (!member.is_defined()) {
       MarkMemberTested(member, false);
       return;
     }
     bool is_positive = *member.cast_to<RTCStatsMember<T>>() > T(0);
     EXPECT_TRUE(is_positive) <<
@@ skipping 228 matching lines @@
     verifier.TestMemberIsNonNegative<double>(
         candidate_pair.total_round_trip_time);
     verifier.TestMemberIsNonNegative<double>(
         candidate_pair.current_round_trip_time);
     if (is_selected_pair) {
       verifier.TestMemberIsNonNegative<double>(
           candidate_pair.available_outgoing_bitrate);
     } else {
       verifier.TestMemberIsUndefined(candidate_pair.available_outgoing_bitrate);
     }
-    verifier.TestMemberIsUndefined(candidate_pair.available_incoming_bitrate);
+    // If we get an available_incoming_bitrate or not seems to depend
+    // on test timing.
+    verifier.TestMemberIsUndefinedOrNonNegative<double>(
+        candidate_pair.available_incoming_bitrate);

[hbos, 2017/05/02 12:58:55]

Can you move this to inside "if (is_selected_pair)" and in the else do
TestMemberIsUndefined?

Ideally with that change TestMemberIsNonNegative should work but if its flaky
it's OK to use TestMemberIsUndefinedOrNonNegative with a // TODO(hbos,nisse):
Find out why this is sometimes undefined, flaky on TSAN. I don't know if the
flake causes a candidate pair to be created that is not selected or if the flake
is that the estimate is not available. Perhaps the flake can be avoided if we
wait for something to happen before we getStats.

Also with this change you seem to have fixed this stat being missing! Can you
add BUG=7062 to the description and remove the comment about populating this
value at
https://cs.chromium.org/chromium/src/third_party/webrtc/api/stats/rtcstats_ob...

[hbos, 2017/05/02 13:00:46]

(Or perhaps "sometimes is defined" is more accurate than "sometimes is
undefined"?)

[nisse-webrtc, 2017/05/05 09:41:19]

Done. Please check if the change is like you intended.
 
"Fixed" is exaggerating, I'm afraid... I've added a TODO and linked to the bug,
but I didn't remove the comment in rtcstats_objects.h.

     verifier.TestMemberIsNonNegative<uint64_t>(
         candidate_pair.requests_received);
     verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.requests_sent);
     verifier.TestMemberIsNonNegative<uint64_t>(
         candidate_pair.responses_received);
     verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.responses_sent);
     verifier.TestMemberIsUndefined(candidate_pair.retransmissions_received);
     verifier.TestMemberIsUndefined(candidate_pair.retransmissions_sent);
     verifier.TestMemberIsUndefined(candidate_pair.consent_requests_received);
     verifier.TestMemberIsNonNegative<uint64_t>(
@@ skipping 245 matching lines @@
   caller_ = nullptr;
   // Any pending stats requests should have completed in the act of destroying
   // the peer connection.
   EXPECT_TRUE(stats_obtainer->report());
 }
 #endif  // HAVE_SCTP
 
 }  // namespace
 
 }  // namespace webrtc