Add PeerConnectionInterface::UpdateCallBitrate with call tests.

webrtc/pc/peerconnectioninterface_unittest.cc

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 3279 matching lines @@
   std::unique_ptr<SessionDescriptionInterface> offer;
   ASSERT_TRUE(DoCreateOffer(&offer, nullptr));
   EXPECT_TRUE(DoSetRemoteDescription(offer.release()));
 
   // Create and set answer as well.
   std::unique_ptr<SessionDescriptionInterface> answer;
   ASSERT_TRUE(DoCreateAnswer(&answer, nullptr));
   EXPECT_TRUE(DoSetLocalDescription(answer.release()));
 }
 
+TEST_F(PeerConnectionInterfaceTest, SetBitrateWithoutMinSucceeds) {
+  CreatePeerConnection();
+  PeerConnectionInterface::BitrateParameters bitrate;
+  bitrate.current_bitrate_bps = rtc::Optional<int>(100000);
+  EXPECT_TRUE(pc_->SetBitrate(bitrate).ok());
+}
+
+TEST_F(PeerConnectionInterfaceTest, SetBitrateNegativeMinFails) {
+  CreatePeerConnection();
+  PeerConnectionInterface::BitrateParameters bitrate;
+  bitrate.min_bitrate_bps = rtc::Optional<int>(-1);
+  EXPECT_FALSE(pc_->SetBitrate(bitrate).ok());
+}
+
+TEST_F(PeerConnectionInterfaceTest, SetBitrateCurrentLessThanMinFails) {
+  CreatePeerConnection();
+  PeerConnectionInterface::BitrateParameters bitrate;
+  bitrate.min_bitrate_bps = rtc::Optional<int>(5);
+  bitrate.current_bitrate_bps = rtc::Optional<int>(3);
+  EXPECT_FALSE(pc_->SetBitrate(bitrate).ok());
+}
+
+TEST_F(PeerConnectionInterfaceTest, SetBitrateCurrentNegativeFails) {
+  CreatePeerConnection();
+  PeerConnectionInterface::BitrateParameters bitrate;
+  bitrate.current_bitrate_bps = rtc::Optional<int>(-1);
+  EXPECT_FALSE(pc_->SetBitrate(bitrate).ok());
+}
+
+TEST_F(PeerConnectionInterfaceTest, SetBitrateMaxLessThanCurrentFails) {
+  CreatePeerConnection();
+  PeerConnectionInterface::BitrateParameters bitrate;
+  bitrate.current_bitrate_bps = rtc::Optional<int>(10);
+  bitrate.max_bitrate_bps = rtc::Optional<int>(8);
+  EXPECT_FALSE(pc_->SetBitrate(bitrate).ok());
+}
+
+TEST_F(PeerConnectionInterfaceTest, SetBitrateMaxLessThanMinFails) {
+  CreatePeerConnection();
+  PeerConnectionInterface::BitrateParameters bitrate;
+  bitrate.min_bitrate_bps = rtc::Optional<int>(10);
+  bitrate.max_bitrate_bps = rtc::Optional<int>(8);
+  EXPECT_FALSE(pc_->SetBitrate(bitrate).ok());
+}
+
+TEST_F(PeerConnectionInterfaceTest, SetBitrateMaxNegativeFails) {
+  CreatePeerConnection();
+  PeerConnectionInterface::BitrateParameters bitrate;
+  bitrate.max_bitrate_bps = rtc::Optional<int>(-1);
+  EXPECT_FALSE(pc_->SetBitrate(bitrate).ok());
+}
+
+TEST_F(PeerConnectionInterfaceTest, SetBitrateCurrentLessThanSdpMin) {

[Taylor Brandstetter, 2017/05/11 04:16:15]

Can you leave a comment above this test explaining what the "SDP min" refers to?

[Zach Stein, 2017/05/11 21:43:09]

I'm not sure this test actually belongs here as is - it is really testing the
interaction between BitrateConfig and BitrateConfigMask, but it doesn't
explicitly do anything to call SetBitrateConfig, so it isn't very easy to
understand. Can you think of a way to make an indirect call to SetBitrateConfig?
If not, maybe we should just remove this (and rely on the Call tests).

[Taylor Brandstetter, 2017/05/11 23:14:08]

I'm fine with relying on the Call tests. But if you keep this, the appropriate
way to trigger SetBitrateConfig with a min would be calling
"SetRemoteDescription" with "x-google-min-bitrate" (could just be in a
hard-coded SDP string; there are examples if you search for it in code search).
Or you could use "b=AS" and try setting a start bitrate greater than the max,
which may be more future-proof.

+  CreatePeerConnection();
+  PeerConnectionInterface::BitrateParameters bitrate;
+  bitrate.current_bitrate_bps = rtc::Optional<int>(1);
+  EXPECT_TRUE(pc_->SetBitrate(bitrate).ok());
+}
+
 class PeerConnectionMediaConfigTest : public testing::Test {
  protected:
   void SetUp() override {
     pcf_ = new rtc::RefCountedObject<PeerConnectionFactoryForTest>();
     pcf_->Initialize();
   }
   const cricket::MediaConfig TestCreatePeerConnection(
       const PeerConnectionInterface::RTCConfiguration& config,
       const MediaConstraintsInterface *constraints) {
 
@@ skipping 272 matching lines @@
   EXPECT_NE(a, f);
 
   PeerConnectionInterface::RTCConfiguration g;
   g.disable_ipv6 = true;
   EXPECT_NE(a, g);
 
   PeerConnectionInterface::RTCConfiguration h(
       PeerConnectionInterface::RTCConfigurationType::kAggressive);
   EXPECT_NE(a, h);
 }