Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java

Issue 2837563002: Pause changing surface size when rendering is paused. (Closed)
Patch Set: Move check inside layoutLock. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java
diff --git a/webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java b/webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java
index 2a9d04f0460bbf5fdbeff16b157780ffdefc0186..ccfb9d0641e7fe35ea5a079cbd8b7691283cc303 100644
--- a/webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java
+++ b/webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java
@@ -41,6 +41,7 @@ public class SurfaceViewRenderer
private RendererCommon.RendererEvents rendererEvents;
private final Object layoutLock = new Object();
+ private boolean isRenderingPaused = false;
private boolean isFirstFrameRendered;
private int rotatedFrameWidth;
private int rotatedFrameHeight;
@@ -177,14 +178,23 @@ public class SurfaceViewRenderer
* reduction.
*/
public void setFpsReduction(float fps) {
+ synchronized (layoutLock) {
+ isRenderingPaused = fps == 0f;
+ }
eglRenderer.setFpsReduction(fps);
}
public void disableFpsReduction() {
+ synchronized (layoutLock) {
+ isRenderingPaused = false;
+ }
eglRenderer.disableFpsReduction();
}
public void pauseVideo() {
+ synchronized (layoutLock) {
+ isRenderingPaused = true;
+ }
eglRenderer.pauseVideo();
}
@@ -295,6 +305,9 @@ public class SurfaceViewRenderer
// Update frame dimensions and report any changes to |rendererEvents|.
private void updateFrameDimensionsAndReportEvents(VideoRenderer.I420Frame frame) {
synchronized (layoutLock) {
+ if (isRenderingPaused) {
+ return;
+ }
if (!isFirstFrameRendered) {
isFirstFrameRendered = true;
logD("Reporting first rendered frame.");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698