webrtc/p2p/base/stunport.cc - Issue 2837133003: Don't crash if STUN error message is missing ERROR-CODE attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/stunport.cc

Issue 2837133003: Don't crash if STUN error message is missing ERROR-CODE attribute. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/p2p/base/stunport.cc

diff --git a/webrtc/p2p/base/stunport.cc b/webrtc/p2p/base/stunport.cc

index 43e8d9fb5c798c8d05ca7b89a99d1d1a2403998b..5801ba7dd63f52122b6764e7d3a1f04c4b19f195 100644

--- a/webrtc/p2p/base/stunport.cc

+++ b/webrtc/p2p/base/stunport.cc

@@ -66,7 +66,7 @@ class StunBindingRequest : public StunRequest {

virtual void OnErrorResponse(StunMessage* response) override {

const StunErrorCodeAttribute* attr = response->GetErrorCode();

if (!attr) {

- LOG(LS_ERROR) << "Bad allocate response error code";

+ LOG(LS_ERROR) << "Missing binding response error code.";

} else {

LOG(LS_ERROR) << "Binding error response:"

<< " class=" << attr->eclass()

« no previous file with comments | « webrtc/p2p/base/stun_unittest.cc ('k') | webrtc/p2p/base/turnport.cc » ('j') | no next file with comments »