Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe.cc

Issue 2835573003: Create experiment for sparse BWE updates (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/congestion_controller/delay_based_bwe.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/congestion_controller/delay_based_bwe.cc
diff --git a/webrtc/modules/congestion_controller/delay_based_bwe.cc b/webrtc/modules/congestion_controller/delay_based_bwe.cc
index 73120381cc665f8f26395fe0f25ead8ff31291b0..2e66e73a28a185f2218b5e42ace2952677f9bba8 100644
--- a/webrtc/modules/congestion_controller/delay_based_bwe.cc
+++ b/webrtc/modules/congestion_controller/delay_based_bwe.cc
@@ -48,6 +48,13 @@ constexpr double kDefaultTrendlineThresholdGain = 4.0;
constexpr int kMaxConsecutiveFailedLookups = 5;
+const char kBweSparseUpdateExperiment[] = "WebRTC-BweSparseUpdateExperiment";
+
+bool BweSparseUpdateExperimentIsEnabled() {
+ std::string experiment_string =
michaelt 2017/04/24 07:00:52 nit: how about use "experiment_status" instead of
+ webrtc::field_trial::FindFullName(kBweSparseUpdateExperiment);
+ return experiment_string == "Enabled";
+}
class PacketFeedbackComparator {
public:
@@ -161,9 +168,9 @@ DelayBasedBwe::DelayBasedBwe(RtcEventLog* event_log, const Clock* clock)
trendline_threshold_gain_(kDefaultTrendlineThresholdGain),
consecutive_delayed_feedbacks_(0),
last_logged_bitrate_(0),
- last_logged_state_(BandwidthUsage::kBwNormal) {
+ last_logged_state_(BandwidthUsage::kBwNormal),
+ in_sparse_update_experiment_(BweSparseUpdateExperimentIsEnabled()) {
LOG(LS_INFO) << "Using Trendline filter for delay change estimation.";
-
network_thread_.DetachFromThread();
}
@@ -195,8 +202,11 @@ DelayBasedBwe::Result DelayBasedBwe::IncomingPacketFeedbackVector(
continue;
delayed_feedback = false;
IncomingPacketFeedback(packet_feedback);
- overusing |= detector_.State() == BandwidthUsage::kBwOverusing;
+ if (!in_sparse_update_experiment_)
+ overusing |= (detector_.State() == BandwidthUsage::kBwOverusing);
}
+ if (in_sparse_update_experiment_)
+ overusing = (detector_.State() == BandwidthUsage::kBwOverusing);
if (delayed_feedback) {
++consecutive_delayed_feedbacks_;
if (consecutive_delayed_feedbacks_ >= kMaxConsecutiveFailedLookups) {
« no previous file with comments | « webrtc/modules/congestion_controller/delay_based_bwe.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698