ObjC: Split out NV12 texture uploading into separate class

webrtc/sdk/objc/Framework/Classes/RTCNV12TextureCache.h

+/*
+ *  Copyright 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#import "WebRTC/RTCVideoFrame.h"

[daniela-webrtc, 2017/04/26 08:56:23]

Can we forward declare this?

[magjed_webrtc, 2017/04/26 13:14:41]

Good idea! Done.

+
+#import <GLKit/GLKit.h>
+
+@interface RTCNV12TextureCache : NSObject
+
+@property(nonatomic, readonly) GLuint yTexture;
+@property(nonatomic, readonly) GLuint uvTexture;
+
+- (instancetype)initWithContext:(EAGLContext *)context;

[daniela-webrtc, 2017/04/26 08:56:23]

You could use Nullability audits (NS_ASSUME_NONNULL_BEGIN) and
(NS_ASSUME_NONNULL_END) and then specify that this can return nullable instance
like so
- (nullable instancetype)initWithContext:(EAGLContext *)context

[magjed_webrtc, 2017/04/26 13:14:41]

Done.

+
+- (BOOL)uploadFrameToTextures:(RTCVideoFrame *)frame;
+
+- (void)releaseTextures;
+
+@end