audioproc_f with simulated mic analog gain

webrtc/modules/audio_processing/test/audio_processing_simulator.h

Index: webrtc/modules/audio_processing/test/audio_processing_simulator.h
diff --git a/webrtc/modules/audio_processing/test/audio_processing_simulator.h b/webrtc/modules/audio_processing/test/audio_processing_simulator.h
index f597fa101a76e7a1a705464957458308fb1b0f81..2893f3aa899ff4ce815a289b8ab739797f524a3a 100644
--- a/webrtc/modules/audio_processing/test/audio_processing_simulator.h
+++ b/webrtc/modules/audio_processing/test/audio_processing_simulator.h
@@ -17,11 +17,12 @@
 #include <memory>
 #include <string>
 
-#include "webrtc/base/timeutils.h"
 #include "webrtc/base/constructormagic.h"
 #include "webrtc/base/optional.h"
+#include "webrtc/base/timeutils.h"
 #include "webrtc/common_audio/channel_buffer.h"
 #include "webrtc/modules/audio_processing/include/audio_processing.h"
+#include "webrtc/modules/audio_processing/test/fake_recording_device.h"
 #include "webrtc/modules/audio_processing/test/test_utils.h"
 
 namespace webrtc {
@@ -74,6 +75,9 @@ struct SimulationSettings {
   rtc::Optional<int> vad_likelihood;
   rtc::Optional<int> ns_level;
   rtc::Optional<bool> use_refined_adaptive_filter;
+  int initial_mic_gain;
+  bool simulate_mic_gain = false;
+  rtc::Optional<int> simulated_mic_kind;

[aleloi, 2017/05/08 10:15:23]

I suggest convert to FakeRecordingDevice::LevelToScalingMappingKind directly and
store as that type. Can Optional<int> agc_mode be changed to an enum at the same
time as well?

[peah-webrtc, 2017/05/08 11:41:33]

That makes sense, but the code storing the command-line flag will be a bit more
messy. As it is now, this is done in the same manner for all parameters using
the SetSettingIfSpecified method. To follow this pattern, a new version of
SetSettingIfSpecified should be created.

That sanity check is for the other parameters now done in
PerformBasicParameterSanityChecks but it could for sure be done in
SetSettingIfSpecified as well.

I don't have a strong opinion, apart from that it should make the code easier to
read and less error prone.

[aleloi, 2017/05/08 12:40:49]

Ok, I didn't look close enough. 

[AleBzk, 2017/05/16 08:53:03]

If I understand well, it's fine as it is now since it's uniform with the rest of
the params.
Therefore, I didn't change anything.

   bool report_performance = false;
   bool report_bitexactness = false;
   bool use_verbose_logging = false;
@@ -164,6 +168,9 @@ class AudioProcessingSimulator {
   AudioFrame rev_frame_;
   AudioFrame fwd_frame_;
   bool bitexact_output_ = true;
+  int last_specified_microphone_level_;
+  int real_recording_device_level_ =
+      FakeRecordingDevice::kRealDeviceLevelUnknown;
 
  private:
   void SetupOutput();
@@ -175,6 +182,7 @@ class AudioProcessingSimulator {
   std::unique_ptr<ChannelBufferWavWriter> reverse_buffer_writer_;
   TickIntervalStats proc_time_;
   std::ofstream residual_echo_likelihood_graph_writer_;
+  FakeRecordingDevice fake_recording_device_;
 
   RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(AudioProcessingSimulator);
 };