audioproc_f with simulated mic analog gain

webrtc/modules/audio_processing/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/arm.gni")
 import("//third_party/protobuf/proto_library.gni")
@@ skipping 482 matching lines @@
       "agc/mock_agc.h",
       "audio_buffer_unittest.cc",
       "beamformer/array_util_unittest.cc",
       "beamformer/complex_matrix_unittest.cc",
       "beamformer/covariance_matrix_generator_unittest.cc",
       "beamformer/matrix_unittest.cc",
       "beamformer/mock_nonlinear_beamformer.h",
       "config_unittest.cc",
       "echo_cancellation_impl_unittest.cc",
       "splitting_filter_unittest.cc",
+      "test/fake_recording_device_unittest.cc",
       "transient/dyadic_decimator_unittest.cc",
       "transient/file_utils.cc",
       "transient/file_utils.h",
       "transient/file_utils_unittest.cc",
       "transient/moving_moments_unittest.cc",
       "transient/transient_detector_unittest.cc",
       "transient/transient_suppressor_unittest.cc",
       "transient/wpd_node_unittest.cc",
       "transient/wpd_tree_unittest.cc",
       "utility/block_mean_calculator_unittest.cc",
       "utility/delay_estimator_unittest.cc",
       "vad/gmm_unittest.cc",
       "vad/pitch_based_vad_unittest.cc",
       "vad/pitch_internal_unittest.cc",
       "vad/pole_zero_filter_unittest.cc",
       "vad/standalone_vad_unittest.cc",
       "vad/vad_audio_proc_unittest.cc",
       "vad/vad_circular_buffer_unittest.cc",
       "vad/voice_activity_detector_unittest.cc",
     ]
 
     deps = [
       ":audio_processing",
       ":audioproc_test_utils",
+      ":fake_recording_device",
       "../..:webrtc_common",
       "../../base:gtest_prod",
       "../../base:protobuf_utils",
       "../../base:rtc_base",
       "../../base:rtc_base_approved",
       "../../common_audio:common_audio",
       "../../system_wrappers:system_wrappers",
       "../../test:test_support",
       "../audio_coding:neteq_unittest_tools",
       "test/conversational_speech:unittest",
@@ skipping 126 matching lines @@
       "//testing/gtest",
     ]
 
     if (rtc_enable_intelligibility_enhancer) {
       defines = [ "WEBRTC_INTELLIGIBILITY_ENHANCER=1" ]
     } else {
       defines = [ "WEBRTC_INTELLIGIBILITY_ENHANCER=0" ]
     }
   }
 
+  rtc_source_set("fake_recording_device") {
+    sources = [
+      "test/fake_recording_device.cc",
+      "test/fake_recording_device.h",
+    ]
+    deps = [
+      "../../base:rtc_base_approved",
+    ]
+  }
+

[AleBzk, 2017/05/17 11:52:22]

I spoke to Alex. Maybe it's too early to consider the use case I had in mind.
So just ignore this point :)
Well, I've tried to put fake rec device into audioproc_f, but then we have
another problem.
fake_recording_device_unittest.cc, currently belonging to the
"audio_processing_unittests" target, depends on fake_recording_device.h/.cc and
fake_rec_device_*.h/.cc. If we remove "fake_recording_device" from the build
file, then we have duplication in it because we need to add the same files in
the deps part of "audio_processing_unittests".

IMHO, I prefer as it is now rather than duplicating the dependencies.
Alternatively, we can create a target for audioproc_f unit tests, but if I think
of this solution, I find it unnecessarily complex.

WDYT?

[peah-webrtc, 2017/05/17 14:52:12]

Good point! Then we need to do this. But then I'd actually rather put this as a
more generic target with a more generic name. As it is now, it is very specific
to the fake_recording_device and if you would add another class to that target
it would not fit the name.

I.e., go for a separate target but I think you should change the name.

[AleBzk, 2017/05/23 13:56:41]

Right, thanks.
fake_recording_device -> analog_mic_simulation

   if (rtc_enable_protobuf) {
     rtc_executable("unpack_aecdump") {
       testonly = true
       sources = [
         "test/unpack.cc",
       ]
 
       deps = [
         ":audio_processing",
         ":audioproc_debug_proto",
@@ skipping 18 matching lines @@
         "test/audioproc_float.cc",
         "test/wav_based_simulator.cc",
         "test/wav_based_simulator.h",
       ]
 
       deps = [
         ":audio_processing",
         ":audioproc_debug_proto",
         ":audioproc_protobuf_utils",
         ":audioproc_test_utils",
+        ":fake_recording_device",
         "../../base:protobuf_utils",
         "../../base:rtc_base_approved",
         "../../common_audio:common_audio",
         "../../system_wrappers",
         "../../system_wrappers:system_wrappers_default",
         "../../test:test_support",
         "//testing/gtest",
         "//third_party/gflags:gflags",
       ]
     }  # audioproc_f
@@ skipping 102 matching lines @@
 
       deps = [
         ":audioproc_debug_proto",
         "../..:webrtc_common",
         "../../base:protobuf_utils",
         "../../base:rtc_base_approved",
       ]
     }
   }
 }