OLD | NEW |
---|---|
1 /* | 1 /* |
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. | 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. |
3 * | 3 * |
4 * Use of this source code is governed by a BSD-style license | 4 * Use of this source code is governed by a BSD-style license |
5 * that can be found in the LICENSE file in the root of the source | 5 * that can be found in the LICENSE file in the root of the source |
6 * tree. An additional intellectual property rights grant can be found | 6 * tree. An additional intellectual property rights grant can be found |
7 * in the file PATENTS. All contributing project authors may | 7 * in the file PATENTS. All contributing project authors may |
8 * be found in the AUTHORS file in the root of the source tree. | 8 * be found in the AUTHORS file in the root of the source tree. |
9 */ | 9 */ |
10 | 10 |
11 #include <algorithm> | |
11 #include <iostream> | 12 #include <iostream> |
13 #include <utility> | |
12 | 14 |
13 #include "webrtc/modules/audio_processing/test/aec_dump_based_simulator.h" | 15 #include "webrtc/modules/audio_processing/test/aec_dump_based_simulator.h" |
14 | 16 |
15 #include "webrtc/base/checks.h" | 17 #include "webrtc/base/checks.h" |
18 #include "webrtc/base/logging.h" | |
16 #include "webrtc/modules/audio_processing/test/protobuf_utils.h" | 19 #include "webrtc/modules/audio_processing/test/protobuf_utils.h" |
17 #include "webrtc/test/testsupport/trace_to_stderr.h" | 20 #include "webrtc/test/testsupport/trace_to_stderr.h" |
18 | 21 |
19 namespace webrtc { | 22 namespace webrtc { |
20 namespace test { | 23 namespace test { |
21 namespace { | 24 namespace { |
22 | 25 |
23 // Verify output bitexactness for the fixed interface. | 26 // Verify output bitexactness for the fixed interface. |
24 // TODO(peah): Check whether it would make sense to add a threshold | 27 // TODO(peah): Check whether it would make sense to add a threshold |
25 // to use for checking the bitexactness in a soft manner. | 28 // to use for checking the bitexactness in a soft manner. |
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
61 } | 64 } |
62 | 65 |
63 } // namespace | 66 } // namespace |
64 | 67 |
65 AecDumpBasedSimulator::AecDumpBasedSimulator(const SimulationSettings& settings) | 68 AecDumpBasedSimulator::AecDumpBasedSimulator(const SimulationSettings& settings) |
66 : AudioProcessingSimulator(settings) {} | 69 : AudioProcessingSimulator(settings) {} |
67 | 70 |
68 AecDumpBasedSimulator::~AecDumpBasedSimulator() = default; | 71 AecDumpBasedSimulator::~AecDumpBasedSimulator() = default; |
69 | 72 |
70 void AecDumpBasedSimulator::PrepareProcessStreamCall( | 73 void AecDumpBasedSimulator::PrepareProcessStreamCall( |
71 const webrtc::audioproc::Stream& msg, | 74 const webrtc::audioproc::Stream& msg) { |
72 bool* set_stream_analog_level_called) { | |
73 if (msg.has_input_data()) { | 75 if (msg.has_input_data()) { |
74 // Fixed interface processing. | 76 // Fixed interface processing. |
75 // Verify interface invariance. | 77 // Verify interface invariance. |
76 RTC_CHECK(interface_used_ == InterfaceType::kFixedInterface || | 78 RTC_CHECK(interface_used_ == InterfaceType::kFixedInterface || |
77 interface_used_ == InterfaceType::kNotSpecified); | 79 interface_used_ == InterfaceType::kNotSpecified); |
78 interface_used_ = InterfaceType::kFixedInterface; | 80 interface_used_ = InterfaceType::kFixedInterface; |
79 | 81 |
80 // Populate input buffer. | 82 // Populate input buffer. |
81 RTC_CHECK_EQ(sizeof(fwd_frame_.data_[0]) * fwd_frame_.samples_per_channel_ * | 83 RTC_CHECK_EQ(sizeof(fwd_frame_.data_[0]) * fwd_frame_.samples_per_channel_ * |
82 fwd_frame_.num_channels_, | 84 fwd_frame_.num_channels_, |
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
149 } | 151 } |
150 | 152 |
151 if (!settings_.use_ts) { | 153 if (!settings_.use_ts) { |
152 if (msg.has_keypress()) { | 154 if (msg.has_keypress()) { |
153 ap_->set_stream_key_pressed(msg.keypress()); | 155 ap_->set_stream_key_pressed(msg.keypress()); |
154 } | 156 } |
155 } else { | 157 } else { |
156 ap_->set_stream_key_pressed(*settings_.use_ts); | 158 ap_->set_stream_key_pressed(*settings_.use_ts); |
157 } | 159 } |
158 | 160 |
159 // TODO(peah): Add support for controlling the analog level via the | 161 // TODO(peah): Add support for controlling the analog level via the |
peah-webrtc
2017/05/05 06:28:41
You can remove this TODO in this CL :-)
AleBzk
2017/05/05 12:20:17
Done.
| |
160 // command-line. | 162 // command-line. |
161 if (msg.has_level()) { | 163 |
162 RTC_CHECK_EQ(AudioProcessing::kNoError, | 164 // Level is always logged in AEC dumps. |
163 ap_->gain_control()->set_stream_analog_level(msg.level())); | 165 RTC_CHECK(msg.has_level()); |
164 *set_stream_analog_level_called = true; | 166 |
165 } else { | 167 // When the analog gain is simulated, set the undo level to |msg.level()| to |
166 *set_stream_analog_level_called = false; | 168 // virtually restore the unmodified microphone signal level. |
169 if (settings_.simulate_mic_gain) { | |
170 fake_recording_device_.NotifyAudioDeviceLevel(msg.level()); | |
peah-webrtc
2017/05/05 06:28:41
I'd prefer all the handling of the fake_recording_
AleBzk
2017/05/05 12:20:17
Right. I made fake_recording_device_ private inste
| |
171 LOG(LS_VERBOSE) << "setting mic gain undo level from AEC dump to " | |
peah-webrtc
2017/05/05 06:28:41
setting->Setting?
AleBzk
2017/05/05 12:20:17
Done.
| |
172 << msg.level(); | |
aleloi
2017/05/04 12:47:13
This would get logged once for every audio frame.
peah-webrtc
2017/05/05 06:28:41
Yes, I agree. The logging here is only in test cod
AleBzk
2017/05/05 12:20:17
I moved this in the ctor so it's shown once.
| |
173 } | |
174 | |
175 // When the analog gain is not simulated, the AEC dump level has to be used in | |
176 // AudioProcessingSimulator::ProcessStream(). | |
177 if (!settings_.simulate_mic_gain) { | |
aleloi
2017/05/04 12:47:13
Suggest merge into the if statement above as an el
AleBzk
2017/05/05 12:20:17
Done.
AleBzk
2017/05/05 12:20:17
Done.
| |
178 fake_recording_device_.set_analog_level(msg.level()); | |
179 LOG(LS_VERBOSE) << "AEC dump overriding AGC suggested level to " | |
180 << msg.level(); | |
167 } | 181 } |
168 } | 182 } |
169 | 183 |
170 void AecDumpBasedSimulator::VerifyProcessStreamBitExactness( | 184 void AecDumpBasedSimulator::VerifyProcessStreamBitExactness( |
171 const webrtc::audioproc::Stream& msg) { | 185 const webrtc::audioproc::Stream& msg) { |
172 if (bitexact_output_) { | 186 if (bitexact_output_) { |
173 if (interface_used_ == InterfaceType::kFixedInterface) { | 187 if (interface_used_ == InterfaceType::kFixedInterface) { |
174 bitexact_output_ = VerifyFixedBitExactness(msg, fwd_frame_); | 188 bitexact_output_ = VerifyFixedBitExactness(msg, fwd_frame_); |
175 } else { | 189 } else { |
176 bitexact_output_ = VerifyFloatBitExactness(msg, out_config_, *out_buf_); | 190 bitexact_output_ = VerifyFloatBitExactness(msg, out_config_, *out_buf_); |
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
555 } | 569 } |
556 | 570 |
557 SetupBuffersConfigsOutputs( | 571 SetupBuffersConfigsOutputs( |
558 msg.sample_rate(), output_sample_rate, msg.reverse_sample_rate(), | 572 msg.sample_rate(), output_sample_rate, msg.reverse_sample_rate(), |
559 reverse_output_sample_rate, msg.num_input_channels(), num_output_channels, | 573 reverse_output_sample_rate, msg.num_input_channels(), num_output_channels, |
560 msg.num_reverse_channels(), num_reverse_output_channels); | 574 msg.num_reverse_channels(), num_reverse_output_channels); |
561 } | 575 } |
562 | 576 |
563 void AecDumpBasedSimulator::HandleMessage( | 577 void AecDumpBasedSimulator::HandleMessage( |
564 const webrtc::audioproc::Stream& msg) { | 578 const webrtc::audioproc::Stream& msg) { |
565 bool set_stream_analog_level_called = false; | 579 PrepareProcessStreamCall(msg); |
566 PrepareProcessStreamCall(msg, &set_stream_analog_level_called); | |
567 ProcessStream(interface_used_ == InterfaceType::kFixedInterface); | 580 ProcessStream(interface_used_ == InterfaceType::kFixedInterface); |
568 if (set_stream_analog_level_called) { | |
569 // Call stream analog level to ensure that any side-effects are triggered. | |
570 (void)ap_->gain_control()->stream_analog_level(); | |
571 } | |
572 | |
573 VerifyProcessStreamBitExactness(msg); | 581 VerifyProcessStreamBitExactness(msg); |
574 } | 582 } |
575 | 583 |
576 void AecDumpBasedSimulator::HandleMessage( | 584 void AecDumpBasedSimulator::HandleMessage( |
577 const webrtc::audioproc::ReverseStream& msg) { | 585 const webrtc::audioproc::ReverseStream& msg) { |
578 PrepareReverseProcessStreamCall(msg); | 586 PrepareReverseProcessStreamCall(msg); |
579 ProcessReverseStream(interface_used_ == InterfaceType::kFixedInterface); | 587 ProcessReverseStream(interface_used_ == InterfaceType::kFixedInterface); |
580 } | 588 } |
581 | 589 |
582 } // namespace test | 590 } // namespace test |
583 } // namespace webrtc | 591 } // namespace webrtc |
OLD | NEW |