Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: webrtc/sdk/android/api/org/webrtc/Camera1Capturer.java

Issue 2833773003: Support adding and removing MediaRecorder to camera 2 session. (Closed)
Patch Set: Address comments - 3 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/sdk/android/api/org/webrtc/Camera2Capturer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/android/api/org/webrtc/Camera1Capturer.java
diff --git a/webrtc/sdk/android/api/org/webrtc/Camera1Capturer.java b/webrtc/sdk/android/api/org/webrtc/Camera1Capturer.java
index fba5711ef83df834414b43def631bed0bc03d67a..f2a813f6b8ca06672af12ef589013ad4542b0c37 100644
--- a/webrtc/sdk/android/api/org/webrtc/Camera1Capturer.java
+++ b/webrtc/sdk/android/api/org/webrtc/Camera1Capturer.java
@@ -10,11 +10,8 @@
package org.webrtc;
-import org.webrtc.CameraEnumerationAndroid.CaptureFormat;
-
import android.content.Context;
-
-import java.util.List;
+import android.media.MediaRecorder;
public class Camera1Capturer extends CameraCapturer {
private final boolean captureToTexture;
@@ -29,8 +26,11 @@ public class Camera1Capturer extends CameraCapturer {
@Override
protected void createCameraSession(CameraSession.CreateSessionCallback createSessionCallback,
CameraSession.Events events, Context applicationContext,
- SurfaceTextureHelper surfaceTextureHelper, String cameraName, int width, int height,
- int framerate) {
+ SurfaceTextureHelper surfaceTextureHelper, MediaRecorder mediaRecorder, String cameraName,
+ int width, int height, int framerate) {
+ if (mediaRecorder != null) {
+ throw new RuntimeException("MediaRecoder is not supported for camera 1.");
+ }
Camera1Session.create(createSessionCallback, events, captureToTexture, applicationContext,
surfaceTextureHelper, Camera1Enumerator.getCameraIndex(cameraName), width, height,
framerate);
« no previous file with comments | « no previous file | webrtc/sdk/android/api/org/webrtc/Camera2Capturer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698