Enabling 'gn check' on webrtc/video

webrtc/media/BUILD.gn

 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/linux/pkg_config.gni")
 import("../webrtc.gni")
@@ skipping 243 matching lines @@
 if (rtc_include_tests) {
   config("rtc_unittest_main_config") {
     # GN orders flags on a target before flags from configs. The default config
     # adds -Wall, and this flag have to be after -Wall -- so they need to
     # come from a config and can"t be on the target directly.
     if (is_clang && is_ios) {
       cflags = [ "-Wno-unused-variable" ]
     }
   }
 
   rtc_source_set("rtc_unittest_main") {

[mbonadei, 2017/04/24 12:10:39]

I think that the _main suffix is misleading here.
It seems to be a set of utilities, should we rename to something else?

[kjellander_webrtc, 2017/04/24 12:41:43]

Yeah, let's rename it to rtc_media_tests_utils. Then it's kind of similar to
//webrtc/base:rtc_base_tests_utils.

     testonly = true
 
     include_dirs = []
     public_deps = []
     deps = [
       "../modules/audio_coding:rent_a_codec",
       "../modules/audio_processing:audio_processing",
       "../p2p:rtc_p2p",
     ]
     sources = [
@@ skipping 31 matching lines @@
 
     deps += [
       ":rtc_media",
       ":rtc_media_base",
       "..:webrtc_common",
       "../api:call_api",
       "../api:video_frame_api",
       "../api/video_codecs:video_codecs_api",
       "../base:rtc_base",
       "../base:rtc_base_approved",
-      "../base:rtc_base_tests_main",
       "../base:rtc_base_tests_utils",
       "../call:call_interfaces",
       "../test:test_support",
       "//testing/gtest",
     ]
     public_deps += [ "//testing/gmock" ]
   }
 
   config("rtc_media_unittests_config") {
     # GN orders flags on a target before flags from configs. The default config
@@ skipping 114 matching lines @@
     deps += [
       ":rtc_media",
       ":rtc_media_base",
       ":rtc_unittest_main",
       "../api:video_frame_api",
       "../api/audio_codecs:builtin_audio_decoder_factory",
       "../api/video_codecs:video_codecs_api",
       "../audio",
       "../base:rtc_base",
       "../base:rtc_base_approved",
+      "../base:rtc_base_tests_main",
       "../base:rtc_base_tests_utils",
       "../call:call_interfaces",
       "../common_video:common_video",
       "../logging:rtc_event_log_api",
       "../modules/audio_device:mock_audio_device",
       "../modules/audio_processing:audio_processing",
       "../modules/video_coding:video_coding_utility",
       "../modules/video_coding:webrtc_vp8",
       "../p2p:p2p_test_utils",
       "../system_wrappers:metrics_default",
       "../test:audio_codec_mocks",
       "../test:test_support",
       "../voice_engine:voice_engine",
     ]
   }
 }